Fix for #7889 and add new lint needless_splitn #7896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
surechen
changed the title
surechen
changed the title
camsteffen
reviewed
Oct 29, 2021
camsteffen
reviewed
Nov 1, 2021
camsteffen
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
@rustbot label: +S-waiting-on-review -S-waiting-on-author |
rustbot
added
S-waiting-on-review
camsteffen
suggested changes
Nov 10, 2021
surechen
changed the title
camsteffen
reviewed
Nov 15, 2021
camsteffen
approved these changes
Nov 16, 2021
1. Fix the problem of manual_split_once changing the original behavior. 2. Add a new lint needless_splitn. changelog: Fix the problem of manual_split_once changing the original behavior and add a new lint needless_splitn.
surechen
force-pushed
the
fix_manual_split_once
branch
from
def7b3e to
c051656
Compare
Done. Thanks. |
|
@bors r+ |
|
📌 Commit c051656 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7889
changelog: Fix the problem of manual_split_once changing the original behavior and add a new lint needless_splitn.