Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: avoid infinite loop in out-of-stack.rs
This fixes #13238. It avoids an infinite loop when compiling the tests with `-g`. Without this change, the debuginfo on `black_box` prevents the method from being inlined, which allows llvm to convert `silent_recurse` into a tail-call. This then loops forever instead of consuming all the stack like it is supposed to. This patch forces inlining `black_box`, which triggers the right error.
- Loading branch information
1b6997d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at erickt@1b6997d
1b6997d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging erickt/rust/remove-refcell-get = 1b6997d into auto
1b6997d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
erickt/rust/remove-refcell-get = 1b6997d merged ok, testing candidate = eae2652
1b6997d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5047
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5047
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4139
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4153
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5147
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4234
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4242
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5149
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4234
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4239
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4305
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2034
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5146
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4243
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4254
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4910
1b6997d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = eae2652