Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GUI test for #131394 #131402

Closed
GuillaumeGomez opened this issue Oct 8, 2024 · 0 comments · Fixed by #132220
Closed

Add GUI test for #131394 #131402

GuillaumeGomez opened this issue Oct 8, 2024 · 0 comments · Fixed by #132220
Assignees
@GuillaumeGomez
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@GuillaumeGomez
Copy link
Member

Once #131394 is merged, need to add a regression GUI test.
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 8, 2024
@GuillaumeGomez GuillaumeGomez self-assigned this Oct 8, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 8, 2024
@GuillaumeGomez GuillaumeGomez removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 8, 2024
@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 27, 2024
Merged
@bors bors closed this as completed in 5c14e3d Oct 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 28, 2024
@rust-timer
Unrolled build for rust-lang#132220
d332b90 
Rollup merge of rust-lang#132220 - GuillaumeGomez:gui-test-struct-fields-margins, r=notriddle

Add GUI regression test for doc struct fields margins

Fixes rust-lang#131402.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GUI regression test for doc struct fields margins GuillaumeGomez/rust
2 participants
@GuillaumeGomez @rustbot