-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICE]: Box<dyn Any> #134059
Labels
A-lints
Area: Lints (warnings about flaws in source code) such as unused_mut.
C-bug
Category: This is a bug.
E-needs-mcve
Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
L-improper_ctypes_definitions
Lint: improper_ctypes_definitions
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
Probably from #131669 cc @niacdoial |
Maybe the same problem as #134060 |
I can repro locally, and I get multiple ICEs locally: One of the multiple backtraces
Notably, I can see (for example) multiple instances of
|
More logs if it helps. |
Ah yes, this is another case of #134060, thanks for the report. I'm going to consolidate the report into the earlier issue. |
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Dec 9, 2024
Revert <rust-lang#131669> due to ICE reports: - <rust-lang#134059> (real-world) - <rust-lang#134060> (fuzzing) The changes can be re-landed with those cases addressed. This reverts commit 703bb98, reversing changes made to f415c07.
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 9, 2024
Revert rust-lang#131669 due to ICEs Revert [lint: change help for pointers to dyn types in FFI rust-lang#131669](rust-lang#131669) due to ICE reports: - <rust-lang#134059> (real-world) - <rust-lang#134060> (fuzzing) Closes rust-lang#134060. The revert criteria I used to assess whether to post this revert was: 1. It's not trivial to fix-forward. (1) The implementation itself is tricky due to `tcx.is_sized` query not being very trivial. (2) It will need more extensive test coverage for different ty kinds. 2. It is impacting real-world crates, i.e. rust-lang#134059. 3. `improper_ctypes_definitions` is a warn-by-default lint. This revert is without prejudice to relanding the changes. The changes can be re-landed with those cases addressed and stronger test coverage. A rough regression test corresponding to the fuzzed example reported in rust-lang#134060 is added to check that the revert worked, it is not sufficient for the lint test coverage when the lint improvements are to be relanded. Please feel free to improve the test in the reland. r? `@workingjubilee` (or compiler) cc `@niacdoial` (PR author)
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 9, 2024
Revert rust-lang#131669 due to ICEs Revert [lint: change help for pointers to dyn types in FFI rust-lang#131669](rust-lang#131669) due to ICE reports: - <rust-lang#134059> (real-world) - <rust-lang#134060> (fuzzing) Closes rust-lang#134060. The revert criteria I used to assess whether to post this revert was: 1. It's not trivial to fix-forward. (1) The implementation itself is tricky due to `tcx.is_sized` query not being very trivial. (2) It will need more extensive test coverage for different ty kinds. 2. It is impacting real-world crates, i.e. rust-lang#134059. 3. `improper_ctypes_definitions` is a warn-by-default lint. This revert is without prejudice to relanding the changes. The changes can be re-landed with those cases addressed and stronger test coverage. A rough regression test corresponding to the fuzzed example reported in rust-lang#134060 is added to check that the revert worked, it is not sufficient for the lint test coverage when the lint improvements are to be relanded. Please feel free to improve the test in the reland. r? `@workingjubilee` (or compiler) cc `@niacdoial` (PR author)
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 9, 2024
Revert rust-lang#131669 due to ICEs Revert [lint: change help for pointers to dyn types in FFI rust-lang#131669](rust-lang#131669) due to ICE reports: - <rust-lang#134059> (real-world) - <rust-lang#134060> (fuzzing) Closes rust-lang#134060. The revert criteria I used to assess whether to post this revert was: 1. It's not trivial to fix-forward. (1) The implementation itself is tricky due to `tcx.is_sized` query not being very trivial. (2) It will need more extensive test coverage for different ty kinds. 2. It is impacting real-world crates, i.e. rust-lang#134059. 3. `improper_ctypes_definitions` is a warn-by-default lint. This revert is without prejudice to relanding the changes. The changes can be re-landed with those cases addressed and stronger test coverage. A rough regression test corresponding to the fuzzed example reported in rust-lang#134060 is added to check that the revert worked, it is not sufficient for the lint test coverage when the lint improvements are to be relanded. Please feel free to improve the test in the reland. r? `@workingjubilee` (or compiler) cc `@niacdoial` (PR author)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-lints
Area: Lints (warnings about flaws in source code) such as unused_mut.
C-bug
Category: This is a bug.
E-needs-mcve
Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
L-improper_ctypes_definitions
Lint: improper_ctypes_definitions
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Affected release channels
Rust Version
Current error output
Backtrace
Anything else?
No response
The text was updated successfully, but these errors were encountered: