Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macro future-proofing regression: $a:ty [ b ] is now rejected #30923

Closed
pnkfelix opened this issue Jan 14, 2016 · 3 comments
Closed

macro future-proofing regression: $a:ty [ b ] is now rejected #30923

pnkfelix opened this issue Jan 14, 2016 · 3 comments
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)

Comments

@pnkfelix
Copy link
Member

(spawned off of #25658 (comment) )

macro future-proofing regression: $a:ty [ b ] is now rejected

This was indeed a direct consequence of the rules as stated in rust-lang/rfcs#1384

But since we may want to fix one-off cases like this, I am opening a separate issue and marking it as a regression.
@pnkfelix
Copy link
Member Author

cc #30450

@pnkfelix pnkfelix mentioned this issue Jan 14, 2016
Merged
@pnkfelix
Copy link
Member Author

cc @nikomatsakis @retep998

@huonw huonw added the A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) label Jan 15, 2016
@durka durka mentioned this issue Jan 23, 2016
Merged
bors added a commit that referenced this issue Jan 23, 2016
@bors
Auto merge of #31152 - durka:ty-follow-bracket, r=pnkfelix
d5fcdcc 
cc #31135 rust-lang/rfcs#1462 #30923 @retep998
r? @pnkfelix
Manishearth added a commit to Manishearth/rust that referenced this issue Jan 26, 2016
@Manishearth
Rollup merge of rust-lang#31152 - durka:ty-follow-bracket, r=pnkfelix
b46bd2f 
cc rust-lang#31135 rust-lang/rfcs#1462 rust-lang#30923 @retep998
r? @pnkfelix
@retep998 retep998 mentioned this issue Feb 4, 2016
Closed
@pnkfelix pnkfelix mentioned this issue Feb 5, 2016
Merged
@LeoTestard
Copy link
Contributor

As of 1.8.0, the following macro compiles on stable:

macro_rules! foo(
    ($a:ty [ $b:ident ]) => ()
);

I think this issue can be closed.

@pnkfelix pnkfelix closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pnkfelix @LeoTestard @huonw