[tidy] binary checked into source false positive #35689
Comments
eddyb
added a commit
to eddyb/rust
that referenced
this issue
Aug 22, 2016
…r=alexcrichton Check that executable file is in-tree before failing tidy check I silenced stdout and stderr for ls-files, not sure if that's appropriate (is `make tidy` intended to give debugging information)? Otherwise it prints each file it find to stdout/stderr, which currently prints nothing (only executable files are checked). I have not done major testing regarding the behavior of ls-files when the file is ignored, but judging by the man page everything should be fine. I've duplicated the code which makes the path git-friendly from the `Cargo.lock` checking code; I can extract that into a common helper if wanted (it's only two lines). Fixes rust-lang#35689.
bors
added a commit
that referenced
this issue
Aug 22, 2016
Check that executable file is in-tree before failing tidy check I silenced stdout and stderr for ls-files, not sure if that's appropriate (is `make tidy` intended to give debugging information)? Otherwise it prints each file it find to stdout/stderr, which currently prints nothing (only executable files are checked). I have not done major testing regarding the behavior of ls-files when the file is ignored, but judging by the man page everything should be fine. I've duplicated the code which makes the path git-friendly from the `Cargo.lock` checking code; I can extract that into a common helper if wanted (it's only two lines). Fixes #35689.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tidy tries to ensure that no binary files get checked into the repository, however, while it finds the binary files, it does not actually checks whether files are committed/staged in git.
The text was updated successfully, but these errors were encountered: