Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit put statements in general functions #87

Closed
graydon opened this issue Jun 28, 2010 · 1 comment
Closed

Prohibit put statements in general functions #87

graydon opened this issue Jun 28, 2010 · 1 comment

Comments

@graydon
Copy link
Contributor

graydon commented Jun 28, 2010

Put statements should only appear in iterators.

@graydon
Copy link
Contributor Author

graydon commented Jul 14, 2010

Fix ret/put mis-identification in typechecker. Closed by 0fdad30.

mbrubeck pushed a commit to mbrubeck/rust that referenced this issue Oct 17, 2011
oli-obk pushed a commit to oli-obk/rust that referenced this issue Jul 19, 2017
replace most uses of `usize` with `u64`
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
Add getxattr()/setxattr() variations
kazcw pushed a commit to kazcw/rust that referenced this issue Oct 23, 2018
- Add "How to write and example" section to CONTRIBUTING.md
 - Add a basic example using `target_feature` to the main page
 - Improve documentation of SSE 4.2
   - Improve documentation of constants
   - Improve documentation of _mm_cmpistri
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
bors pushed a commit to rust-lang-ci/rust that referenced this issue Oct 1, 2021
djtech-dev pushed a commit to djtech-dev/rust that referenced this issue Dec 9, 2021
add bindings for LLVMGet{I,F}CmpPredicate
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Add tests for rust-lang#564, rust-lang#208 and rust-lang#87.

Unfortunately, it looks like there are still issues with with how we are
encoding panic threads and dynamic objects which are causing two of the
test cases to fail.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Oct 31, 2024
Adds an `Invariant` trait to `core::ub_checks`, and adds two invariants
for `Alignment` and `Layout`.

One call-out: Kani's invariant trait
[enforces](https://github.com/model-checking/kani/blob/d2051b77437a0032120f0513e0e9c3c4766d8562/library/kani/src/invariant.rs#L63)
that the type is sized, but I wasn't sure why that would be necessary,
so I didn't add it here.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Celina G. Val <[email protected]>
carolynzech pushed a commit to celinval/rust-dev that referenced this issue Dec 13, 2024
…ion (rust-lang#136)

Resolves rust-lang#72 

We added invariants for Nanoseconds and Duration to match the safety
conditions for those types.

We add safety requirements to the following methods:
- `new`, `from_secs`, `from_millis`, `from_micros`, `from_nanos`,
`as_secs`, `as_millis`, `as_micros`, `as_nanos`, `subsec_millis`,
`subsec_micros`, `subsec_nanos`, `checked_add`, `checked_sub`,
`checked_mul`, `checked_div`

We additionally add correctness conditions to the following methods:
- `from_secs`, `as_secs`, `subsec_millis`, `subsec_micros`,
`subsec_nanos`, `as_millis`, `as_micros`

Support for `kani::Invariant` depends on rust-lang#87. For the interim we
implemented a proxy trait `TempInvariant` that exposes the same
`is_safe` method. We will update this once rust-lang#87 is merged.

While the safety check for `Duration::as_nanos()` succeeds, we ran into
timeouts for `Duration::as_nanos()` when we tried to use a correctness
contract and we're looking for advice on how to speed up that
verification time. We were able to prove it for `u16::MAX`, but hit
timeouts for larger numbers.

We are unsure if the pre-conditions for `Duration::new()` are acceptable
because they limit the range of values that you can call
`Duration::new()` with. However, we think it's reasonable since we limit
the values to values that don't panic. Let us know if this is a thing
that we should change.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Cole Vick <[email protected]>
Co-authored-by: Celina G. Val <[email protected]>
Co-authored-by: Michael Tautschnig <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant