std::run: Use Result instead of condition #10654
Conversation
Previously `std::run::Process::new()` raised a io_error condition then tried to unwrap `None`, so it caused assertion failure. This fixes the problem by returning Result instead of raising condition. This also fixes rustc ICE on nonexistent `--linker`.
|
I'm cancelling the build because I do not believe that this is the correct way to go about this today. We haven't yet removed conditions, and having one and only one I/O interface use I do believe that this fixes a bug in the meantime, but I don't think that using |
|
@alexcrichton Will #10449 change all io_error to IoResult? Then I would close this and just file an issue, since it will fix (or at least provide a good way to fix) the issue correctly. However I think the main issue can't be easily fixed with |
Add configuration for `semicolon_block` lints Does exactly what it says on the tin, suggests moving a block's final semicolon inside if it's multiline and outside if it's singleline. I don't really like how this is implemented so I'm not too sure if this is ready yet. Alas, it might be ok. --- fixes rust-lang#10654 changelog: Enhancement: [`semicolon_inside_block`]: Added `semicolon-inside-block-ignore-singleline` as a new config value. [rust-lang#10656](rust-lang/rust-clippy#10656) changelog: Enhancement: [`semicolon_outside_block`]: Added `semicolon-outside-block-ignore-multiline` as a new config value. [rust-lang#10656](rust-lang/rust-clippy#10656) <!-- changelog_checked -->
Previously
std::run::Process::new()raised a io_error condition thentried to unwrap
None, so it caused assertion failure.This fixes the problem by returning Result instead of raising
condition.
This also fixes rustc ICE on nonexistent
--linker.