Move some utils out of rustc_const_eval
#110397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
These commits modify the If this was intentional then you can ignore this comment. Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
This PR combined with #110396 reduced |
|
r=me unless you want a reviewer from t-compiler |
fee1-dead
approved these changes
Apr 16, 2023
|
r? @fee1-dead @bors r=fee1-dead,jyn514 |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Apr 16, 2023
…e1-dead,jyn514 Move some utils out of `rustc_const_eval` This allows us to get rid of the `rustc_const_eval->rustc_borrowck` dependency edge which was delaying the compilation of borrowck. The added utils in `rustc_middle` are small and should not affect compile times there.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
…fee1-dead Rollup of 4 pull requests Successful merges: - rust-lang#110397 (Move some utils out of `rustc_const_eval`) - rust-lang#110398 (use matches! macro in more places) - rust-lang#110400 (more clippy fixes: clippy::{iter_cloned_collect, unwarp_or_else_defau…) - rust-lang#110402 (Remove the loop in `Align::from_bytes`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Cc #100061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to get rid of the
rustc_const_eval->rustc_borrowckdependency edge which was delaying the compilation of borrowck.The added utils in
rustc_middleare small and should not affect compile times there.