Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smaller ints for bitflags #111022

Merged
merged 1 commit into from
May 8, 2023
Merged

Use smaller ints for bitflags #111022

merged 1 commit into from
May 8, 2023

Conversation

Noratrieb
Copy link
Member

Free shrinking!

@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2023
@Noratrieb
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 30, 2023
@bors
Copy link
Contributor

bors commented Apr 30, 2023

⌛ Trying commit bb93b8dae72f3ee0be7e860d3dc627d2a003841a with merge 8e9090dd2a0988134ab8824daeb67807daaf1559...

@compiler-errors
Copy link
Member

r=me if perf comes back good (and comment is removed)

@bors
Copy link
Contributor

bors commented Apr 30, 2023

☀️ Try build successful - checks-actions
Build commit: 8e9090dd2a0988134ab8824daeb67807daaf1559 (8e9090dd2a0988134ab8824daeb67807daaf1559)

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 30, 2023

☀️ Try build successful - checks-actions
Build commit: 8e9090dd2a0988134ab8824daeb67807daaf1559 (8e9090dd2a0988134ab8824daeb67807daaf1559)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8e9090dd2a0988134ab8824daeb67807daaf1559): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.1% [-3.5%, -0.4%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.1% [-3.5%, -0.4%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2023
@Noratrieb Noratrieb force-pushed the smaller-bitflags branch from bb93b8d to 8013703 Compare May 7, 2023 16:24
@Noratrieb Noratrieb force-pushed the smaller-bitflags branch from 8013703 to f264577 Compare May 7, 2023 16:25
@Noratrieb
Copy link
Member Author

@bors r=compiler-errors rollup=maybe

@bors
Copy link
Contributor

bors commented May 7, 2023

📌 Commit f264577 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2023
@bors
Auto merge of rust-lang#111342 - Dylan-DPC:rollup-b5p6wzy, r=Dylan-DPC
c86e7fb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#110297 (Make `(try_)subst_and_normalize_erasing_regions` take `EarlyBinder`)
 - rust-lang#110827 (Fix lifetime suggestion for type aliases with objects in them)
 - rust-lang#111022 (Use smaller ints for bitflags)
 - rust-lang#111056 (Fix some suggestions where a `Box<T>` is expected.)
 - rust-lang#111262 (Further normalize msvc-non-utf8-ouput)
 - rust-lang#111265 (Make generics_of has_self on RPITITs delegate to the opaque)
 - rust-lang#111323 (Give a more helpful error when running the rustc shim directly)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c75543d into rust-lang:master May 8, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 8, 2023
@Noratrieb Noratrieb deleted the smaller-bitflags branch May 8, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@saethlin saethlin saethlin left review comments

@jyn514 jyn514 jyn514 left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Noratrieb @rustbot @rust-timer @bors @compiler-errors @saethlin @jyn514 @oli-obk