Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc_encodable_decodable feature #134272

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Remove rustc_encodable_decodable feature #134272

merged 2 commits into from
Feb 2, 2025

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 13, 2024 •
edited
Loading

This has been shown in future-compat reports since Rust 1.79 (#116016), released June 2024. Let's see if crater still finds any issues.

Part of #134301.

Cc @rust-lang/libs-api

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 13, 2024
@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 2993504 to 3ce5d1d Compare December 13, 2024 17:38
@RalfJung
Copy link
Member Author

RalfJung commented Dec 13, 2024 •
edited
Loading

Hm, seeing the discussion in #116016 it seems like the plan was to move much more slowly with this? There's no separate tracking issue for the de-stabilization of this as far as I can see, so it's all a bit unclear.

I guess we'll see what crater says.
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
@bors
Auto merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodable…
79200d6 
…_decodable, r=<try>

make rustc_encodable_decodable feature properly unstable

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues.

Cc `@rust-lang/libs-api`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 3ce5d1d with merge 79200d6...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 3ce5d1d to 88960fd Compare December 13, 2024 18:10
@RalfJung
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
@bors
Auto merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodable…
09ea730 
…_decodable, r=<try>

make rustc_encodable_decodable feature properly unstable

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues.

Cc `@rust-lang/libs-api`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 88960fd with merge 09ea730...

@compiler-errors compiler-errors added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2024
@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: 09ea730 (09ea730c380b8b9acb96ff87b724c45df920f793)

@RalfJung RalfJung mentioned this pull request Dec 13, 2024
Merged
@RalfJung
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-134272 created and queued.
🤖 Automatically detected try build 09ea730
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@RalfJung RalfJung mentioned this pull request Dec 14, 2024
Open
@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 88960fd to e9804a3 Compare December 14, 2024 10:04
@jhpratt
Copy link
Member

jhpratt commented Dec 14, 2024

I don't think there really was a plan — soft destabilizing it was the extent to which it was discussed afaik.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 14, 2024 •
edited
Loading

There's some mixed messaging here: the ACP says "full destabilization is not proposed due to breakage of existing code", but the lint that is emitted when using these types says this "will become a hard error in a future release".

@jhpratt
Copy link
Member

jhpratt commented Dec 14, 2024

Ha, that's 100% on me. It must have been discussed on Zulip, as I wasn't aware soft destabilization was a thing before that. Anyways, it doesn't much matter.

@RalfJung
Copy link
Member Author

Well, seems like nobody complained about the future compat "this will become a hard error" warning that we have emitted for more than half a year now (and that is shown even when this occurs just in a dependency), so let's just see what crater says.

@RalfJung RalfJung mentioned this pull request Dec 14, 2024
Open
@craterbot
Copy link
Collaborator

🚧 Experiment pr-134272 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-134272 is completed!
📊 286 regressed and 48 fixed (553892 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 18, 2024
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 24, 2025
@rustbot rustbot assigned wesleywiser and unassigned ibraheemdev Jan 24, 2025
@RalfJung RalfJung changed the title make rustc_encodable_decodable feature properly unstable Remove rustc_encodable_decodable feature Jan 24, 2025
cuviper added a commit to cuviper/num-bigint that referenced this pull request Jan 25, 2025
@cuviper
Disable rustc-serialize derives for future compilers
6b11ef8 
The built-in derives are being [removed], but crater showed problems
with crates depending on `num v0.1`, where this feature is enabled by
default. With this PR, we detect the missing built-ins and disable the
derives, adding a build-script warning about it. Cargo won't show such
warnings by default from non-path dependencies, unless the build fails.

[removed]: rust-lang/rust#134272
@cuviper cuviper mentioned this pull request Jan 25, 2025
Merged
cuviper added a commit to cuviper/num-complex that referenced this pull request Jan 25, 2025
@cuviper
Disable rustc-serialize derives for future compilers
1359337 
The built-in derives are being [removed], but crater showed problems
with crates depending on `num v0.1`, where this feature is enabled by
default. With this PR, we detect the missing built-ins and disable the
derives, adding a build-script warning about it. Cargo won't show such
warnings by default from non-path dependencies, unless the build fails.

[removed]: rust-lang/rust#134272
@cuviper cuviper mentioned this pull request Jan 25, 2025
Merged
cuviper added a commit to cuviper/num-rational that referenced this pull request Jan 25, 2025
@cuviper
Disable rustc-serialize derives for future compilers
b74aa52 
The built-in derives are being [removed], but crater showed problems
with crates depending on `num v0.1`, where this feature is enabled by
default. With this PR, we detect the missing built-ins and disable the
derives, adding a build-script warning about it. Cargo won't show such
warnings by default from non-path dependencies, unless the build fails.

[removed]: rust-lang/rust#134272
@cuviper cuviper mentioned this pull request Jan 25, 2025
Merged
cuviper added a commit to cuviper/num that referenced this pull request Jan 25, 2025
@cuviper
Disable rustc-serialize derives for future compilers
21d5794 
The built-in derives are being [removed], but crater showed problems
with crates depending on `num v0.1`, where this feature is enabled by
default. With this PR, we detect the missing built-ins and disable the
derives, adding a build-script warning about it. Cargo won't show such
warnings by default from non-path dependencies, unless the build fails.

For `num` itself, this mostly just amounts to a dependency bump.

[removed]: rust-lang/rust#134272
@cuviper cuviper mentioned this pull request Jan 25, 2025
Merged
@cuviper
Copy link
Member

cuviper commented Jan 25, 2025

Test build 09ea730c380b8b9acb96ff87b724c45df920f793 works with these updates:

  • num-bigint v0.1.45
  • num-complex v0.1.44
  • num-rational v0.1.43
  • num v0.1.43

@RalfJung
Copy link
Member Author

Awesome, thanks a lot :)

@ehuss ehuss mentioned this pull request Jan 26, 2025
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Feb 2, 2025

r? oli-obk @bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2025

📌 Commit 9ac62f9 has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned wesleywiser Feb 2, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodab…
69338c2 
…le_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc `@rust-lang/libs-api`
This was referenced Feb 2, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
@bors
Auto merge of rust-lang#136448 - matthiaskrgr:rollup-pdim5di, r=matth…
4a43094 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134272 (Remove rustc_encodable_decodable feature)
 - rust-lang#136283 (Update encode_utf16 to mention it is native endian)
 - rust-lang#136394 (Clean up MonoItem::instantiation_mode)
 - rust-lang#136402 (diagnostics: fix borrowck suggestions for if/while let conditionals)
 - rust-lang#136415 (Highlight clarifying information in "expected/found" error)
 - rust-lang#136422 (Convert two `rustc_middle::lint` functions to `Span` methods.)
 - rust-lang#136434 (rustc_allowed_through_unstable_modules: require deprecation message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48aede0 into rust-lang:master Feb 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
@rust-timer
Unrolled build for rust-lang#134272
84bd933 
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodable_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc ``@rust-lang/libs-api``
@RalfJung RalfJung deleted the destabilize-rustc_encodable_decodable branch February 3, 2025 11:02
@ehuss ehuss mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.