Rollup of 5 pull requests #134380

matthiaskrgr · 2024-12-16T11:09:01Z

Successful merges:

Remove rustc::existing_doc_keyword lint #134202 (Remove rustc::existing_doc_keyword lint)
Handle fndef rendering together with signature rendering #134354 (Handle fndef rendering together with signature rendering)
Use links to edition guide for edition migrations #134368 (Use links to edition guide for edition migrations)
Check for array lengths that aren't actually usize #134371 (Check for array lengths that aren't actually usize)
An octuple of polonius fact generation cleanups #134378 (An octuple of polonius fact generation cleanups)

Failed merges:

Rename rustc_mir_build::build to builder #134365 (Rename rustc_mir_build::build to builder)

r? @ghost
@rustbot modify labels: rollup

All the other unconditional keywords are in the alphabetical order, but `while` is for some reason not.

`CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed.

- remove dependency on `TypeChecker` - move to legacy fact generation module

- remove dependency on `TypeChecker` - move to legacy fact generation module - remove polonius module from liveness

- remove dependency on `TypeChecker` - move to legacy fact generation module - group facts emitted during typeck together

also remove a useless trace

- integrate it within existing fact generation instead of being called in typeck - simplify access fact extraction - also remove single use fact emit functions in root fact generation

- integrate into `emit_facts` and remove from typeck

- use a consistent name for `TypeChecker`, which is usually referred to as `typeck` - remove an incorrect doc comment - remove a single-use local

- fix names - fix ordering of arguments

…d, r=GuillaumeGomez,nnethercote Remove `rustc::existing_doc_keyword` lint The check doesn't require a lint. r? ```@GuillaumeGomez```

…ler-errors Handle fndef rendering together with signature rendering Pulled out of rust-lang#134353 Changes some highlighting in type mismatch errors around fndefs

Use links to edition guide for edition migrations This switches the migration lints for the 2024 edition to point to the edition guide documentation instead of the tracking issues. I expect the documentation should be easier to understand for a user, compared to most of the issues which don't have any direct information, and can be a bit confusing to navigate, or have outdated information.

Check for array lengths that aren't actually `usize` I wish typeck wouldn't give us `ty::Array`s that have this problem in the first place, but we can check for it. Fixes rust-lang#134352 cc `@matthiaskrgr`

…kh726 An octuple of polonius fact generation cleanups This PR is extracted from rust-lang#134268 for easier review and contains its first 8 commits. They have already been reviewed by `@jackh726` over there. r? `@jackh726`

matthiaskrgr · 2024-12-16T11:09:17Z

@bors r+ rollup=never p=5

bors · 2024-12-16T11:09:21Z

📌 Commit 8085a8b has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-12-16T12:12:59Z

⌛ Testing commit 8085a8b with merge a79fb6a...

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134378 (An octuple of polonius fact generation cleanups) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-12-16T13:05:33Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-12-16T12:48:29Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T12:48:29Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:48:29Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpxoRtFT#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T12:48:30Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:48:30Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpxoRtFT#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpxoRtFT\\incremental-state"
[2024-12-16T12:48:31Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:48:31Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpxoRtFT#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpxoRtFT\\incremental-state"
[2024-12-16T12:48:32Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpxoRtFT"
[2024-12-16T12:48:32Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T12:48:32Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T12:48:32Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpxoRtFT#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpxoRtFT\\incremental-state"
[2024-12-16T12:48:33Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T12:48:33Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:48:33Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpJUZb7I#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T12:48:34Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
[2024-12-16T12:51:16Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T12:51:18Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:51:18Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpRcuCbq#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T12:51:45Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:51:45Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpRcuCbq#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpRcuCbq\\incremental-state"
[2024-12-16T12:52:18Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:52:18Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpRcuCbq#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpRcuCbq\\incremental-state"
[2024-12-16T12:52:23Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpRcuCbq"
[2024-12-16T12:52:23Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T12:52:23Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T12:52:23Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpRcuCbq#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpRcuCbq\\incremental-state"
[2024-12-16T12:52:28Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T12:52:30Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:52:30Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpu2Dvkw#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T12:53:27Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
[2024-12-16T12:56:42Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T12:56:42Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:56:42Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnSFJxA#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T12:56:44Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:56:44Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnSFJxA#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpnSFJxA\\incremental-state"
[2024-12-16T12:56:46Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T12:56:46Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnSFJxA#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpnSFJxA\\incremental-state"
Executing benchmark token-stream-stress (7/8)
Preparing token-stream-stress
[2024-12-16T12:56:46Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None, backend=Llvm, phase=dependencies
[2024-12-16T12:56:46Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None, backend=Llvm, phase=dependencies
---
   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 4.841
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\symbols.o" "<1 object files omitted>" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_driver-599d2e5155ecfc93.dll.lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib/{libcompiler_builtins-c25bba97e86b102c.rlib}" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustccHmHhd\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\stacker-51665ada3368c7c5\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\psm-49e517f07a604d4e\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-9f5cbfe9164854a2\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-9f5cbfe9164854a2\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-2e0139d76762918c\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-0f980120ffe133e1.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-0f980120ffe133e1.exe'␍
          

[RUSTC-TIMING] rustc_main test:false 0.649

bors · 2024-12-16T13:06:17Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-12-16T13:12:30Z

@bors retry

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134378 (An octuple of polonius fact generation cleanups) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-16T15:50:45Z

⌛ Testing commit 8085a8b with merge dd8feec...

matthiaskrgr · 2024-12-16T18:49:00Z

@bors r+

bors · 2024-12-16T18:49:02Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 9 pull requests #134393

bors · 2024-12-16T18:49:03Z

📌 Commit 8085a8b has been approved by matthiaskrgr

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134378 (An octuple of polonius fact generation cleanups) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-16T19:00:38Z

⌛ Testing commit 8085a8b with merge e823167...

rust-log-analyzer · 2024-12-16T20:07:53Z

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

-rw-rw-r--  1 runner runner  29M Dec 16 19:58 rust-std-nightly-x86_64-unknown-linux-gnux32.tar.xz
-rw-rw-r--  1 runner runner  13M Dec 16 20:03 rust-std-nightly-x86_64-unknown-none.tar.xz
-rw-rw-r--  1 runner runner  23M Dec 16 20:06 rust-std-nightly-x86_64-unknown-uefi.tar.xz

Attempting with retry: aws s3 cp --storage-class INTELLIGENT_TIERING --no-progress --recursive --acl public-read /tmp/tmp.iy7MKOoDGw s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109
upload: ../../../../../tmp/tmp.iy7MKOoDGw/image-dist-various-2.txt to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/image-dist-various-2.txt
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-aarch64-unknown-fuchsia.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-aarch64-unknown-fuchsia.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-nvptx64-nvidia-cuda.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-nvptx64-nvidia-cuda.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-armv7-unknown-linux-gnueabi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-armv7-unknown-linux-gnueabi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-i686-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-i686-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-aarch64-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-aarch64-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-armv7-unknown-linux-musleabi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-armv7-unknown-linux-musleabi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-i686-unknown-freebsd.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-i686-unknown-freebsd.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/metrics-dist-various-2.json to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/metrics-dist-various-2.json
upload: ../../../../../tmp/tmp.iy7MKOoDGw/cpu-dist-various-2.csv to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/cpu-dist-various-2.csv
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-sparcv9-sun-solaris.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-sparcv9-sun-solaris.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-riscv64gc-unknown-linux-musl.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-riscv64gc-unknown-linux-musl.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-wasm32-wasip1-threads.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-wasm32-wasip1-threads.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-wasm32-unknown-unknown.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-wasm32-unknown-unknown.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-wasm32-wasip1.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-wasm32-wasip1.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-wasm32-wasip2.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-wasm32-wasip2.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-fortanix-unknown-sgx.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-fortanix-unknown-sgx.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-wasm32v1-none.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-wasm32v1-none.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-pc-solaris.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-pc-solaris.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-unknown-fuchsia.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-unknown-fuchsia.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-unknown-none.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-unknown-none.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-analysis-nightly-x86_64-unknown-linux-gnux32.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-analysis-nightly-x86_64-unknown-linux-gnux32.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-aarch64-unknown-fuchsia.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-aarch64-unknown-fuchsia.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-aarch64-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-aarch64-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-armv7-unknown-linux-gnueabi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-armv7-unknown-linux-gnueabi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-i686-unknown-freebsd.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-i686-unknown-freebsd.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-armv7-unknown-linux-musleabi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-armv7-unknown-linux-musleabi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-nvptx64-nvidia-cuda.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-nvptx64-nvidia-cuda.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-i686-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-i686-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-wasm32-unknown-unknown.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-wasm32-unknown-unknown.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-sparcv9-sun-solaris.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-sparcv9-sun-solaris.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-riscv64gc-unknown-linux-musl.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-riscv64gc-unknown-linux-musl.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-wasm32-wasip1.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-wasm32-wasip1.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-wasm32v1-none.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-wasm32v1-none.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-wasm32-wasip2.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-wasm32-wasip2.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-fortanix-unknown-sgx.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-fortanix-unknown-sgx.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-wasm32-wasip1-threads.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-wasm32-wasip1-threads.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-unknown-fuchsia.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-unknown-fuchsia.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-pc-solaris.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-pc-solaris.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-unknown-uefi.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-unknown-uefi.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-unknown-linux-gnux32.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-unknown-linux-gnux32.tar.xz
upload: ../../../../../tmp/tmp.iy7MKOoDGw/rust-std-nightly-x86_64-unknown-none.tar.xz to s3://rust-lang-ci2/rustc-builds/e82316767a4acff4486d18279145329daa912109/rust-std-nightly-x86_64-unknown-none.tar.xz
npm install -g @datadog/datadog-ci@^2.x.x
python3 src/ci/scripts/upload-build-metrics.py build/cpu-usage.csv
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
  DATADOG_SITE: datadoghq.com
  DATADOG_API_KEY: ***
  DD_GITHUB_JOB_NAME: auto - dist-various-2
##[endgroup]
npm error code ETARGET
npm error notarget No matching version found for @aws-sdk/[email protected].
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-16T20_07_33_684Z-debug-0.log
##[error]Process completed with exit code 1.

bors · 2024-12-16T20:08:40Z

💔 Test failed - checks-actions

nnethercote and others added 19 commits December 12, 2024 19:58

Move doc(keyword = "while").

4638a58

All the other unconditional keywords are in the alphabetical order, but `while` is for some reason not.

Fix rustdoc GUI test

bdbaeae

clean up emit_access_facts

2fd4438

- remove dependency on `TypeChecker` - move to legacy fact generation module

clean up emit_drop_facts

9d8f58a

- remove dependency on `TypeChecker` - move to legacy fact generation module - remove polonius module from liveness

clean up translate_outlives_facts

afbe101

- remove dependency on `TypeChecker` - move to legacy fact generation module - group facts emitted during typeck together

use let else more consistently in fact generation

5486857

also remove a useless trace

simplify emit_access_facts and fact generation

1740a5f

- integrate it within existing fact generation instead of being called in typeck - simplify access fact extraction - also remove single use fact emit functions in root fact generation

simplify emit_outlives_facts

2024c5d

- integrate into `emit_facts` and remove from typeck

refactor type_check module slightly

7ad1f5b

- use a consistent name for `TypeChecker`, which is usually referred to as `typeck` - remove an incorrect doc comment - remove a single-use local

improve consistency within fact gen

8562497

- fix names - fix ordering of arguments

Use links to edition guide for edition migrations

3e80697

Check for array lengths that aren't actually usize

43a79a0

Handle fndef rendering together with signature rendering

e40a494

Rollup merge of rust-lang#134202 - nnethercote:rm-existing_doc_keywor…

17c89b0

…d, r=GuillaumeGomez,nnethercote Remove `rustc::existing_doc_keyword` lint The check doesn't require a lint. r? ```@GuillaumeGomez```

Rollup merge of rust-lang#134354 - oli-obk:push-nlrxswvpqnuk, r=compi…

081c440

…ler-errors Handle fndef rendering together with signature rendering Pulled out of rust-lang#134353 Changes some highlighting in type mismatch errors around fndefs

Rollup merge of rust-lang#134371 - scottmcm:fix-134352, r=oli-obk

a49c303

Check for array lengths that aren't actually `usize` I wish typeck wouldn't give us `ty::Array`s that have this problem in the first place, but we can check for it. Fixes rust-lang#134352 cc `@matthiaskrgr`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Dec 16, 2024

matthiaskrgr closed this Dec 16, 2024

matthiaskrgr reopened this Dec 16, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

jieyouxu mentioned this pull request Dec 16, 2024

[CI] Use a lockfile for installing the datadog package #134095

Merged

matthiaskrgr closed this Dec 17, 2024

matthiaskrgr deleted the rollup-a47jc6z branch January 25, 2025 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #134380

Rollup of 5 pull requests #134380

matthiaskrgr commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

Rollup of 5 pull requests #134380

Rollup of 5 pull requests #134380

Conversation

matthiaskrgr commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

matthiaskrgr commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024