compiletest: include stage0-sysroot libstd dylib in recipe dylib search path #135389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
weirdly, i just got bootstrap itself failing due to not being able to find libstd (i was just trying to run i don't really know how to repro, maybe it has something to do with switching branches, or maybe there was some change to rpath calculation that needs to be reverted. also one time i had the opposite problem, where there were two possible versions of libstd, and bootstrap (or was it rustc?) couldn't decide which to use. |
|
Sometimes between compiler bumps and bootstrap changes you may need to |
|
that's a command implemented in the rust side of bootstrap, which i cannot build. i think i need to rebuild everything, which probably isn't happening today. |
|
yeah removing |
onur-ozkan
approved these changes
Jan 12, 2025
…ch path To fix some of the failures in `COMPILETEST_FORCE_STAGE0=1 ./x test run-make --stage 0`.
jieyouxu
force-pushed
the
fix-stage0-rustdoc-rmake
branch
from
18a10b9 to
1665b80
Compare
|
Addressed the nit. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135266 (Remove emsdk version update from 1.84.0 relnotes) - rust-lang#135364 (Cleanup `suggest_binding_for_closure_capture_self` diag in borrowck) - rust-lang#135375 (allow rustdoc-js tests to be run at stage0) - rust-lang#135379 (Make (unstable API) `UniqueRc` invariant for soundness) - rust-lang#135389 (compiletest: include stage0-sysroot libstd dylib in recipe dylib search path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
Rollup merge of rust-lang#135389 - jieyouxu:fix-stage0-rustdoc-rmake, r=onur-ozkan compiletest: include stage0-sysroot libstd dylib in recipe dylib search path To fix some of the failures in `COMPILETEST_FORCE_STAGE0=1 ./x test run-make --stage 0`. Specifically, ``` COMPILETEST_FORCE_STAGE0=1 ./x test tests/run-make/rustdoc-default-output/ --stage 0 ``` should now pass. Fixes rust-lang#135373. (As in, make *some* of the `run-make` tests pass, other `run-make` tests fail for various reasons against stage0, and generally `run-make` tests are not guaranteed to pass at stage 0.) cc `@lolbinarycat` r? bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix some of the failures in
COMPILETEST_FORCE_STAGE0=1 ./x test run-make --stage 0. Specifically,should now pass.
Fixes #135373. (As in, make some of the
run-maketests pass, otherrun-maketests fail for various reasons against stage0, and generallyrun-maketests are not guaranteed to pass at stage 0.)cc @lolbinarycat
r? bootstrap