Move std::io::pipe code into its own file
#135635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This is a duplicate of #135583. As the other one is approved already, I'm closing this one. Feel free to reopen if the other PR does not address everything done here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
tbu-
changed the title
std::pipe::{pipe, PipeReader, PipeWriter} to std::iostd::io::pipe code into its own file
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tbu- could you rebase? |
I'll open a stabilization PR. |
|
The merge is conflict-free but GH does not automatically drop commits, so the diff view is incorrect. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Great, thank you! |
rustbot
added
S-waiting-on-review
|
@bors r=joboet |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#126604 (Uplift `clippy::double_neg` lint as `double_negations`) - rust-lang#135158 (Add `TooGeneric` variant to `LayoutError` and emit `Unknown`) - rust-lang#135635 (Move `std::io::pipe` code into its own file) - rust-lang#136072 (add two old crash tests) - rust-lang#136079 (compiler_fence: fix example) - rust-lang#136091 (Add some tracing to core bootstrap logic) - rust-lang#136097 (rustc_ast: replace some len-checks + indexing with slice patterns etc.) - rust-lang#136101 (triagebot: set myself on vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup merge of rust-lang#135635 - tbu-:pr_io_pipe, r=joboet Move `std::io::pipe` code into its own file Also update the docs for the new location, create a section "Platform-specific behavior", don't hide required imports for code examples.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 29, 2025
Test pipes also when not running on Windows and Linux simultaneously Fixes rust-lang#135635 (review). Based on top of rust-lang#135635 to avoid merge conflicts.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 29, 2025
Test pipes also when not running on Windows and Linux simultaneously Fixes rust-lang#135635 (review). Based on top of rust-lang#135635 to avoid merge conflicts.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2025
Rollup merge of rust-lang#136092 - tbu-:pr_io_pipe_test, r=joboet Test pipes also when not running on Windows and Linux simultaneously Fixes rust-lang#135635 (review). Based on top of rust-lang#135635 to avoid merge conflicts.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 31, 2025
Test pipes also when not running on Windows and Linux simultaneously Fixes rust-lang/rust#135635 (review). Based on top of #135635 to avoid merge conflicts.
|
@bors r- ('fixing' desync) |
bors
added
S-waiting-on-author
|
isn;t this PR akready merged? |
|
Yes but the bors queue is slightly out of sync atm and this merged PR showed up in the "merge queue", I had to kick it out. We have a proper procedure for resyncing the queue but that takes ~45 minutes and I didn't want to do that rn (for several reasons). |
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Feb 20, 2025
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Feb 20, 2025
github-actions bot
pushed a commit
to carolynzech/rust
that referenced
this pull request
Feb 20, 2025
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Feb 20, 2025
github-actions bot
pushed a commit
to thanhnguyen-aws/verify-rust-std
that referenced
this pull request
Feb 21, 2025
github-actions bot
pushed a commit
to thanhnguyen-aws/verify-rust-std
that referenced
this pull request
Feb 21, 2025
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Feb 22, 2025
github-actions bot
pushed a commit
to carolynzech/rust
that referenced
this pull request
Feb 22, 2025
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Feb 22, 2025
github-actions bot
pushed a commit
to thanhnguyen-aws/verify-rust-std
that referenced
this pull request
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the docs for the new location, create a section "Platform-specific behavior", don't hide required imports for code examples.