Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit unused args warnings for intrinsics without body #135840

Merged
merged 1 commit into from
Feb 1, 2025
Merged

omit unused args warnings for intrinsics without body #135840

merged 1 commit into from
Feb 1, 2025

Conversation

vayunbiyani
Copy link
Contributor

potential fix for #135598

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@vayunbiyani
Copy link
Contributor Author

@oli-obk Could you please help me understand how I can go about adding a test case for this? Should I add a function in tests/ui/liveness/liveness-unused.rs and adjust the stderr?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jan 22, 2025

Should I add a function in tests/ui/liveness/liveness-unused.rs and adjust the stderr?

Yea that's probably the best place. The intrinsic ui tests like most other ui tests hide such lints so you'd have to add the annotations to make the lints appear again.

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jan 23, 2025

lgtm. Please squash the commits

@vayunbiyani vayunbiyani force-pushed the omit_intrinsic_unused_param_warning branch from a150414 to 8e22ec0 Compare January 23, 2025 19:36
@vayunbiyani
Copy link
Contributor Author

@RalfJung based on this comment, the test args were prefixed with a _ as a workaround to avoid the unused args warnings

This PR fixes the underlying bug; would it be worth rolling those back?

@oli-obk oli-obk marked this pull request as ready for review January 23, 2025 20:40
@vayunbiyani
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2025
@RalfJung
Copy link
Member

RalfJung commented Jan 23, 2025 via email

vayunbiyani added a commit to vayunbiyani/rust that referenced this pull request Jan 31, 2025
@vayunbiyani
updated single line functions to use , revert the changes in this com…
79945a8 
…mit once rust-lang#135840 is merged
@vayunbiyani
Copy link
Contributor Author

@oli-obk just wanted to check in here, did you get a chance to review and merge this?

@oli-obk
Copy link
Contributor

oli-obk commented Jan 31, 2025

@bors r+

@bors
Copy link
Contributor

bors commented Jan 31, 2025

📌 Commit 8e22ec0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025
RalfJung
RalfJung reviewed Jan 31, 2025
View reviewed changes
compiler/rustc_passes/src/liveness.rs
if let Some(intrinsic) =
self.ir.tcx.intrinsic(self.ir.tcx.hir().body_owner_def_id(body.id()))
{
if intrinsic.must_be_overridden {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this wrong? It seems like it will silence the warning even for intrinsics with a body.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm, that's exactly what must_be_overridden checks for. A comment would be a good idea. :)

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 31, 2025
@workingjubilee
Rollup merge of rust-lang#135840 - vayunbiyani:omit_intrinsic_unused_…
0b999bf 
…param_warning, r=oli-obk

omit unused args warnings for intrinsics without body

potential fix for rust-lang#135598
@workingjubilee workingjubilee mentioned this pull request Jan 31, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@bors
Auto merge of rust-lang#136367 - workingjubilee:rollup-pud5uj0, r=wor…
1bc23f1 
…kingjubilee

Rollup of 16 pull requests

Successful merges:

 - rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
 - rust-lang#135768 (tests: Port `symbol-mangling-hashed` to rmake.rs)
 - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL)
 - rust-lang#135840 (omit unused args warnings for intrinsics without body)
 - rust-lang#135900 (Manually walk into WF obligations in `BestObligation` proof tree visitor)
 - rust-lang#136146 (Explicitly choose x86 softfloat/hardfloat ABI)
 - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
 - rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program)
 - rust-lang#136266 (fix broken release notes id)
 - rust-lang#136283 (Update encode_utf16 to mention it is native endian)
 - rust-lang#136309 (set rustc dylib on manually constructed rustc command)
 - rust-lang#136314 (Use proper type when applying deref adjustment in const)
 - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets)
 - rust-lang#136348 (miri: make float min/max non-deterministic)
 - rust-lang#136351 (Add documentation for derive(CoercePointee))
 - rust-lang#136358 (`#[optimize(none)]` implies `#[inline(never)]`)

Failed merges:

 - rust-lang#135994 (Rename rustc_middle::Ty::is_unsafe_ptr to is_raw_ptr)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 1, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2025
@bors
Auto merge of rust-lang#136371 - matthiaskrgr:rollup-0b880v3, r=matth…
9e48dfe 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135840 (omit unused args warnings for intrinsics without body)
 - rust-lang#135900 (Manually walk into WF obligations in `BestObligation` proof tree visitor)
 - rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program)
 - rust-lang#136266 (fix broken release notes id)
 - rust-lang#136314 (Use proper type when applying deref adjustment in const)
 - rust-lang#136348 (miri: make float min/max non-deterministic)
 - rust-lang#136351 (Add documentation for derive(CoercePointee))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2460b28 into rust-lang:master Feb 1, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 1, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2025
@rust-timer
Unrolled build for rust-lang#135840
1400ee8 
Rollup merge of rust-lang#135840 - vayunbiyani:omit_intrinsic_unused_param_warning, r=oli-obk

omit unused args warnings for intrinsics without body

potential fix for rust-lang#135598
@RalfJung RalfJung mentioned this pull request Feb 1, 2025
Merged
@vayunbiyani vayunbiyani deleted the omit_intrinsic_unused_param_warning branch February 6, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vayunbiyani @rustbot @rust-log-analyzer @oli-obk @RalfJung @bors