Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove erroneous unsafe in BTreeSet::upper_bound_mut #135883

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove erroneous unsafe in BTreeSet::upper_bound_mut #135883

merged 1 commit into from
Jan 23, 2025

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jan 22, 2025 •
edited by tgross35
Loading

#128309 (comment)

Tracking issue: #107540

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 22, 2025
Merged
@hkBst
Copy link
Member

hkBst commented Jan 22, 2025

#128309 (comment)
r? @Mark-Simulacrum

@rustbot rustbot assigned Mark-Simulacrum and unassigned tgross35 Jan 22, 2025
@tgross35
Copy link
Contributor

This is consistent with lower_bound_mut and matches what is described at the tracking issue #107540.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit bae2a2f has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
@tgross35 tgross35 assigned tgross35 and unassigned Mark-Simulacrum Jan 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#135883 - GrigorenkoPV:btree_set_upper_bound…
e9509f4 
…_mut, r=tgross35

Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`

rust-lang#128309 (comment)

Tracking issue: rust-lang#107540
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135906 - matthiaskrgr:rollup-k08iwsq, r=matth…
5431177 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#131282 (std: detect stack overflows in TLS destructors on UNIX)
 - rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
 - rust-lang#135790 (Update windows-gnu targets to set `DebuginfoKind::DWARF`)
 - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
 - rust-lang#135879 (fix outdated file path ref in llvm)
 - rust-lang#135883 (Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`)
 - rust-lang#135884 (remove implied end of slice)
 - rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 23, 2025
@jhpratt
Rollup merge of rust-lang#135883 - GrigorenkoPV:btree_set_upper_bound…
67f0ca0 
…_mut, r=tgross35

Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`

rust-lang#128309 (comment)

Tracking issue: rust-lang#107540
@jhpratt jhpratt mentioned this pull request Jan 23, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 23, 2025
@jieyouxu
Rollup merge of rust-lang#135883 - GrigorenkoPV:btree_set_upper_bound…
f9ef37d 
…_mut, r=tgross35

Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`

rust-lang#128309 (comment)

Tracking issue: rust-lang#107540
@jieyouxu jieyouxu mentioned this pull request Jan 23, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135915 - jhpratt:rollup-m965rf3, r=jhpratt
26089bc 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
 - rust-lang#135552 ([AIX] Lint on structs that have a different alignment in AIX's C ABI)
 - rust-lang#135764 (Fix tests on LLVM 20)
 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135790 (Update windows-gnu targets to set `DebuginfoKind::DWARF`)
 - rust-lang#135879 (fix outdated file path ref in llvm)
 - rust-lang#135883 (Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`)
 - rust-lang#135884 (remove implied end of slice)
 - rust-lang#135887 (improvements on `build_steps::test` implementation)
 - rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135921 - matthiaskrgr:rollup-5mzn76m, r=matth…
99768c8 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
 - rust-lang#135552 ([AIX] Lint on structs that have a different alignment in AIX's C ABI)
 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135790 (Update windows-gnu targets to set `DebuginfoKind::DWARF`)
 - rust-lang#135879 (fix outdated file path ref in llvm)
 - rust-lang#135883 (Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut`)
 - rust-lang#135884 (remove implied end of slice)
 - rust-lang#135887 (improvements on `build_steps::test` implementation)
 - rust-lang#135898 (rustdoc-json-types: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d1cfd39 into rust-lang:master Jan 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 23, 2025
@GrigorenkoPV GrigorenkoPV deleted the btree_set_upper_bound_mut branch January 23, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GrigorenkoPV @rustbot @hkBst @tgross35 @bors @Mark-Simulacrum