Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable gen_future Feature Tracking #137061

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Unstable gen_future Feature Tracking #137061

merged 2 commits into from
Feb 24, 2025

Conversation

progressive-galib
Copy link
Contributor

@progressive-galib progressive-galib commented Feb 15, 2025 •
edited by workingjubilee
Loading

This PR removes the reference to the closed tracking issue #50547 for the gen_future feature. Since gen_future is an internal feature used in async block desugaring, it does not require a public tracking issue.

Changes:

  • Replaced issue = "50547" with issue = "none" in library/core/src/future/mod.rs.
  • Ensures that it is correctly identified as an internal feature.

Rationale:

With this change, the Unstable Book will now state:

"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."

Closes #76249. 🚀🦀

@progressive-galib
replaced the four occurrences of issue ="50547" in
e2b5225 
library/core/src/future/mod.rs with issue = "none"
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ibraheemdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 15, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee workingjubilee changed the title ### Fixes https://github.com/rust-lang/rust/issues/76249 Unstable gen_future Feature Tracking Unstable gen_future Feature Tracking Feb 15, 2025
@workingjubilee
Copy link
Member

tidy is very fussy about formatting, please bless.

@progressive-galib
Copy link
Contributor Author

progressive-galib commented Feb 15, 2025 •
edited
Loading

tidy is very fussy about formatting, please bless.

done tiding up,

🎵I'll stop the world and Rust with you 🎵

🎵We'd rather run the world with rust 🎵
@workingjubilee

@progressive-galib
Copy link
Contributor Author

@workingjubilee can ask something off topic ? my local machine is kinda meh and good enough for running intellisense or linter let alone compile. i wrote a github codespace config to work on rust.

should i open another pr to merge it in so others can use it to work on this using standardized config and not waste time writing a config each time anyone have to use codespace ?

@ibraheemdev
Copy link
Member

Thanks. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2025

📌 Commit e52534f has been approved by ibraheemdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2025
@jhpratt jhpratt mentioned this pull request Feb 24, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2025
@bors
Auto merge of rust-lang#137511 - jhpratt:rollup-07whsax, r=jhpratt
bb029a1 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#136610 (Allow `IndexSlice` to be indexed by ranges.)
 - rust-lang#136991 ([rustdoc] Add new setting to wrap source code lines when too long)
 - rust-lang#137061 (Unstable `gen_future` Feature Tracking  )
 - rust-lang#137393 (Stabilize `unbounded_shifts`)
 - rust-lang#137482 (Windows: use existing wrappers in `File::open_native`)
 - rust-lang#137484 (Fix documentation for unstable sort on slice)
 - rust-lang#137491 (Tighten `str-to-string-128690.rs``CHECK{,-NOT}`s to make it less likely to incorrectly fail with symbol name mangling)
 - rust-lang#137495 (Added into_value function to ControlFlow<T, T>)
 - rust-lang#137501 (Move `impl` blocks out of `rustc_middle/src/mir/syntax.rs`)
 - rust-lang#137505 (Add a span to `CompilerBuiltinsCannotCall`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7f11ef into rust-lang:master Feb 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 24, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2025
@rust-timer
Unrolled build for rust-lang#137061
4de6256 
Rollup merge of rust-lang#137061 - progressive-galib:gen_future-closing#76249, r=ibraheemdev

Unstable `gen_future` Feature Tracking

This PR removes the reference to the closed tracking issue **rust-lang#50547** for the `gen_future` feature. Since `gen_future` is an internal feature used in async block desugaring, it does not require a public tracking issue.

#### Changes:
- Replaced `issue = "50547"` with `issue = "none"` in **library/core/src/future/mod.rs**.
- Ensures that it is correctly identified as an internal feature.

#### Rationale:
With this change, the Unstable Book will now state:
> *"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."*

Closes **rust-lang#76249**. 🚀🦀
@fmease fmease mentioned this pull request Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
6 participants
@progressive-galib @rustbot @rust-log-analyzer @workingjubilee @ibraheemdev @bors