-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement initial version of cfg(accessible(..))
#137113
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in compiler/rustc_attr_parsing These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This doesn't seems to share any code with the already implemented What's the plan with that earlier attempt? Replace it with this one? |
I guess we can decide that after the we work out the "advice on organizing these code" part :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be existing tests at tests/ui/conditional-compilation/cfg_accessible-*
, maybe these should stay in the same place? Or just make a new cfg-accessible
directory and move everything there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, will move those files in the next push. Any advice on the implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know too much about this area of the compiler unfortunately, petrochenkov is probably the expert here. Just happened to notice the existing tests while doing a driveby of this feature's history.
☔ The latest upstream changes (presumably #135726) made this pull request unmergeable. Please resolve the merge conflicts. |
Implements an initial version of
cfg(accessible(..))
. The code includes a fewFIXME
s, and i think i need some help with understanding how things suppose to work before i can solve them. Also, maybe i need some advice on organizing these code.I'll assign to Vadim but feel free to reassign.
cc #64797
r? @petrochenkov