Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsyntax: Allow + to separate trait bounds. #14365

Closed
wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

This breaks some code that looked like 1 as u32 + 2, because now +
is part of the type grammar. Change it to (1 as u32) + 2.

Part of #12778.

[breaking-change]

r? @alexcrichton

This breaks some code that looked like `1 as u32 + 2`, because now `+`
is part of the type grammar. Change it to `(1 as u32) + 2`.

Part of rust-lang#12778.

[breaking-change]
@lilyball
Copy link
Contributor

It seems unfortunate to break 1 as u32 + 2, especially because u32 can't be a trait here (it's not a trait object, and you can't coerce to a trait directly). Although obviously the same case applies to &x as &TraitFoo + 2.

@alexcrichton
Copy link
Member

I talked with @pcwalton in person about this, and we agree that this needs an RFC first because it's changing the syntax of the language.

@brson
Copy link
Contributor

brson commented May 23, 2014

Closing until we see an rfc.

@brson brson closed this May 23, 2014
@huonw
Copy link
Member

huonw commented May 23, 2014

rust-lang/rfcs#87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants