Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #20427 #22093

Merged
merged 2 commits into from
Feb 13, 2015
Merged

Fix issue #20427 #22093

merged 2 commits into from
Feb 13, 2015

Conversation

petrochenkov
Copy link
Contributor

Names of structs, enums, traits, type aliases and type parameters (i.e. all identifiers that can be used as full paths in type position) are not allowed to match the names of primitive types.
See #20427 for more information.

This is a minor [breaking-change]

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pnkfelix Feb 8, 2015
@pnkfelix
Copy link
Member

@bors r+ 6457c9f

@bors
Copy link
Contributor

bors commented Feb 12, 2015

⌛ Testing commit 6457c9f with merge bd220c4...

bors added a commit that referenced this pull request Feb 12, 2015
Names of structs, enums, traits, type aliases and type parameters (i.e. all identifiers that can be used as full paths in type position) are not allowed to match the names of primitive types.
See #20427 for more information.

This is a minor [breaking-change]
@bors
Copy link
Contributor

bors commented Feb 12, 2015

💔 Test failed - auto-mac-32-opt

@petrochenkov
Copy link
Contributor Author

duplicate error code E0316, will fix today

@petrochenkov
Copy link
Contributor Author

Fixed.

@alexcrichton
Copy link
Member

@bors: r=pnkfelix 8ed58d8

@bors
Copy link
Contributor

bors commented Feb 12, 2015

⌛ Testing commit 8ed58d8 with merge ac23a12...

@bors
Copy link
Contributor

bors commented Feb 12, 2015

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 12, 2015

⌛ Testing commit 8ed58d8 with merge 367cb63...

bors added a commit that referenced this pull request Feb 12, 2015
Names of structs, enums, traits, type aliases and type parameters (i.e. all identifiers that can be used as full paths in type position) are not allowed to match the names of primitive types.
See #20427 for more information.

This is a minor [breaking-change]
@bors
Copy link
Contributor

bors commented Feb 12, 2015

💔 Test failed - auto-mac-64-nopt-t

@petrochenkov
Copy link
Contributor Author

error: could not write output to ...: No space left on device

o_O
I guess one more retry won't help?

@aturon
Copy link
Member

aturon commented Feb 13, 2015

I think one of the bots ran out of space and @brson has since cleaned it up.

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 13, 2015

⌛ Testing commit 8ed58d8 with merge cf636c2...

bors added a commit that referenced this pull request Feb 13, 2015
Names of structs, enums, traits, type aliases and type parameters (i.e. all identifiers that can be used as full paths in type position) are not allowed to match the names of primitive types.
See #20427 for more information.

This is a minor [breaking-change]
@bors bors merged commit 8ed58d8 into rust-lang:master Feb 13, 2015
@petrochenkov petrochenkov deleted the builtin branch May 9, 2015 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants