(cargo) fixed a package installation bug, cleaned up usage #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where os::copy_file was called with a directory name, and updates the command line options and usage messages for clarity.
Since `os::copy_file` wasn't preserving the executable permissions, this reverts back to `run::run_program` and `cp` to install the packages.
erickt
added a commit
that referenced
this pull request
May 29, 2012
(cargo) fixed a package installation bug, cleaned up usage
|
Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
Improve information sharing across SB diagnostics Previous Stacked Borrows diagnostics were missing a lot of information about the state of the interpreter, and it was difficult to add additional state because it was threaded through all the intervening function signatures. This change factors a lot of the arguments which used to be passed individually to many stacked borrows functions into a single `DiagnosticCx`, which is built in `Stacks::for_each`, and since it wraps a handle to `AllocHistory`, we can now handle more nuanced things like heterogeneous borrow of `!Freeze` types.
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
This fixes a regression from rust-lang#2439. The compiler should store the location of the function body instead of the declaration. Storing the correct location fixes how concrete playback stores the generated unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where os::copy_file was called with a directory name, and
updates the command line options and usage messages for clarity.