[MIR] Handle coercion casts properly when building the MIR #33303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixes rust-lang#33295
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Aatch
changed the title
|
@bors r+ |
|
📌 Commit 3906aef has been approved by |
bors
added a commit
that referenced
this pull request
May 1, 2016
[MIR] Handle coercion casts properly when building the MIR Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixes #33295 /cc @eddyb
|
💔 Test failed - auto-mac-64-opt-rustbuild |
@alexcrichton @bors retry |
|
💔 Test failed - auto-win-msvc-32-opt |
What the **** - cc @nikomatsakis @michaelwoerister @bors retry |
|
💔 Test failed - auto-linux-64-opt-mir |
|
@bors retry |
|
💔 Test failed - auto-win-msvc-64-opt-mir |
|
@bors: retry On Sun, May 1, 2016 at 10:46 AM, bors [email protected] wrote:
|
|
Spurious because of #31657 |
bors
added a commit
that referenced
this pull request
May 2, 2016
[MIR] Handle coercion casts properly when building the MIR Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixes #33295 /cc @eddyb
This was referenced May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coercion casts (
expr as Twhere the type ofexprcan be coerced toT) are essentially no-ops, as the actual work is done by a coercion.Previously a check for type equality was used to avoid emitting the
redundant cast in the MIR, but this failed for coercion casts of
function items that had lifetime parameters. The MIR trans code doesn't
handle
FnPtr -> FnPtrcasts and produced an error.Also fixes a bug with type ascription expressions not having any
adjustments applied.
Fixes #33295
/cc @eddyb