-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku: several smaller fixes to build and run rust on Haiku #51757
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
executables on x86_64 With the switch to gcc 7 the linker scripts don't always explicitly add the `-pie` flag anymore. This creates build failures on x86_64. Interestingly enough, adding this flag on i686 will lead to executables that fail to run when ASLR is enabled, so let's keep it x86_64 only.
ping from triage, @pnkfelix ,will you have time to review this PR in near future? |
ping from triage @pnkfelix @rust-lang/compiler , will you have time to review this PR in near future? |
@bors r+ Seems good to me. |
📌 Commit bbe45ce has been approved by |
Haiku: several smaller fixes to build and run rust on Haiku This PR combines three small patches that help Rust build and run on the Haiku platform. These patches do not intend to impact other platforms.
☀️ Test successful - status-appveyor, status-travis |
This PR combines three small patches that help Rust build and run on the Haiku platform. These patches do not intend to impact other platforms.