-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] add condition to check if the value is moved #56811
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, just need to check for a partial move.
desired_action.as_verb_in_past_tense() | ||
), | ||
); | ||
if used_place.is_prefix_of(&moved_place) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be checking that if, for any of the MoveSite
in move_site_vec
, the Place
associated with that MoveSite
is a prefix of used_place
. I describe how to get the Place
for a MoveSite
in the mentor instructions.
err.span_label( | ||
span, | ||
format!( | ||
"value {} here after partial move", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to change the message based on an if
rather than the entire span_label
call? ie.
err.span_label(
span,
format!(
"value {} here{}",
desired_action.as_verb_in_past_tense(),
if is_partial_move { " after partial move" } else { "" },
)
);
@Dylan-DPC are you still working on this and able to address the feedback? |
@davidtwco was working on something else, will get back to it in a few days |
Triage; @Dylan-DPC Hello, have you been able to get back to this PR? |
@Aaronepower will work on it this week |
Ping from triage @Dylan-DPC: What is the status of this PR? |
@TimNN thanks. this week or i'll close it myself and work on it in the future. 👍 |
Going to close this as it seems this is being handled by someone else. Feel free to re-open. |
closes #56657
r? @davidtwco