Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #66099 - Added the upper and lower bounds to the documentation of all integer types. #66664

Closed
wants to merge 1 commit into from

Conversation

segfaultsourcery
Copy link

I quickly came to the realization that the only way to reliably get the numbers is to hard-code them and pass them through to the macros int_module! and uint_module!. I've changed the code, run through the tests, and seen that the documentation does update in the appropriate places.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019
@segfaultsourcery
Copy link
Author

This is in response to issue 66099, #66099

I'll gladly spend some more time refining this until it fits your style better.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2019
@JohnCSimon
Copy link
Member

JohnCSimon commented Nov 30, 2019

Ping from triage:
@cramertj Can you please review this PR and provide any additional feedback to segfaultsourcery? Thanks.

@ohadravid
Copy link
Contributor

I'm also trying to solve this more generally in #66221

@cramertj
Copy link
Member

cramertj commented Dec 2, 2019

This PR seems fine to me, but it might not be a bad idea to wait and see if #66221 can land, making this unnecessary.

@Dylan-DPC-zz Dylan-DPC-zz added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2019
@segfaultsourcery
Copy link
Author

I can't believe I missed #66221. I hope it lands, it's a really nice idea.

@jplatte
Copy link
Contributor

jplatte commented Jan 3, 2020

Since #66221 has been merged, I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants