-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using Self::
in doc
#71289
Allow using Self::
in doc
#71289
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
We do not allow merge commits, kindly rebase and re-commit the change :) |
thank you and done |
After a discussion with @xliiv, I got a better understanding of why they were using /// Text
/// [Link][Self::foo]
///
/// ```
/// // We are inside a trait implementation
/// let x = &array[foo][Self::x];
/// ```
I thought about two solutions to handle this:
Now that I think about it, when you declare a trait or even a struct, I think that |
This makes sense more to me, so the solution would be to
this should just work now AFAIK (see #70802) @GuillaumeGomez if you can hint me where is the right place to store |
Btw, this example data
|
TODO: check fields too
thanks to @GuillaumeGomez |
@xliiv we do not allow merge commits. can you rebase instead? thanks |
Self::
in doc of methods Self::
in doc of methods
@Dylan-DPC |
I understand, but it is easier fixing it now with lesser commits than when you have more commits to rebase :D |
Self::
in doc of methods Self::
in doc of methods
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Blocked by #72173 |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Please ping me once #72173 is merged (and please rebase at that time so the CI can pass too!) so I can review with everything ready. :) |
@GuillaumeGomez done and ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me! Just the newly added feature that seems weird.
My question has been answered, therefore we can move forward. Thanks a lot for implementing it! @bors: r+ |
📌 Commit 94cf2c69dba94a74b0847749595f522a8a73e95b has been approved by |
@bors rollup |
Also it could be replaced with |
@bors: r+ |
📌 Commit fc0675b has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#71289 (Allow using `Self::` in doc) - rust-lang#72375 (Improve E0599 explanation) - rust-lang#72385 (Add some teams to prioritization exclude_labels) - rust-lang#72395 (Allow rust-highfive to label issues it creates.) - rust-lang#72453 (Add flag to open docs: x.py doc --open) - rust-lang#72459 (Add core::future::IntoFuture) - rust-lang#72461 (Clean up E0600 explanation) Failed merges: r? @ghost
Closes #70802