-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention that some atomic operations may not be available on some platforms #72998
Conversation
…n is not always available
(rust_highfive has picked a reviewer for you, use r? to override) |
@rust-lang/libs -- this seems fine to me, though I don't myself know the details of the support of various atomic types across the platforms we support. |
I think the message should briefly explain what conditions are required for the type/method to exist on a particular target. |
Should I just copy the |
Something along the lines of "This type is only available on platforms that support atomic loads and stores of $inttype" for the types and "This method is only available on platforms that support atomic operations on $inttype" for methods. |
…platform's capabilities
Thanks for the suggestion, it helped ! I also moved the |
Co-authored-by: Amanieu d'Antras <[email protected]>
@bors r+ rollup Thanks! |
📌 Commit 5398456 has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#72764 (Be more careful around ty::Error in generators) - rust-lang#72908 (rename FalseEdges -> FalseEdge) - rust-lang#72970 (Properly handle feature-gated lints) - rust-lang#72998 (Mention that some atomic operations may not be available on some platforms) - rust-lang#73063 (Elide type on liballoc vec) Failed merges: r? @ghost
fixes #54250
This simply adds a line saying the type/function/method may not be available on some platforms, depending on said platform capabilities.
I think I got them all.