Fix error codes check run and ensure it will not go unnoticed again #83451
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
added
the
A-error-codes
src/tools/tidy/src/main.rs
Outdated
| @@ -31,7 +31,7 @@ fn main() { | |||
|
|
|||
| // Checks that only make sense for the compiler. | |||
| errors::check(&compiler_path, &mut bad); | |||
| error_codes_check::check(&src_path, &mut bad); | |||
| error_codes_check::check(&[&src_path, &compiler_path], &mut bad); | |||
There was a problem hiding this comment.
Hm, what error codes exist under src/? Should we actually split this into two separate passes, one to collect tests under src/test/ui/error-codes and the other for errors in the compiler?
There was a problem hiding this comment.
Under src are the tests. We check that all error codes are emitted at least in one test. I think it'd be hard to split the two parts considering that on one side we iterate over all emitted error codes and on the other we list all error codes. At the end, we check that all listed error codes have been tested once.
|
ping @Mark-Simulacrum |
|
OK, seems reasonable enough. Thanks. @bors r+ rollup=iffy |
|
📌 Commit 865d0c6 has been approved by |
bors
added
S-waiting-on-bors
…check, r=Mark-Simulacrum Fix error codes check run and ensure it will not go unnoticed again Fixes rust-lang#83268. The error codes explanations were not checked anymore. I fixed this issue and also added variables to ensure that this won't happen again (at least not silently).
|
☔ The latest upstream changes (presumably #82347) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
fix-error-code-tidy-check
branch
from
865d0c6 to
a41d41c
Compare
|
Fixed conflicts. @bors: r=Mark-Simulacrum |
|
📌 Commit a41d41c has been approved by |
bors
added
S-waiting-on-bors
…check, r=Mark-Simulacrum Fix error codes check run and ensure it will not go unnoticed again Fixes rust-lang#83268. The error codes explanations were not checked anymore. I fixed this issue and also added variables to ensure that this won't happen again (at least not silently).
|
☀️ Test successful - checks-actions |
Fixes #83268.
The error codes explanations were not checked anymore. I fixed this issue and also added variables to ensure that this won't happen again (at least not silently).