Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip late bound regions in GATSubstCollector #98219

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

eggyal
Copy link
Contributor

@eggyal eggyal commented Jun 18, 2022

#93227 liberated late bound regions when collecting GAT substs in wfcheck. It should simply skip late bound regions instead.

r? @compiler-errors

rust-lang#93227 liberated late bound regions when collecting GAT substs in wfcheck.  It should simply skip late bound regions instead.

r? @compiler-errors
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 18, 2022

📌 Commit c51f508 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 19, 2022
…lding, r=jackh726

Skip late bound regions in GATSubstCollector

rust-lang#93227 liberated late bound regions when collecting GAT substs in wfcheck.  It should simply skip late bound regions instead.

r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98105 (rustdoc: remove tuple link on round braces)
 - rust-lang#98136 (Rename `impl_constness` to `constness`)
 - rust-lang#98146 (Remove --memory-init-file flag when linking with Emscripten)
 - rust-lang#98219 (Skip late bound regions in GATSubstCollector)
 - rust-lang#98233 (Remove accidental uses of `&A: Allocator`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf3245e into rust-lang:master Jun 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 19, 2022
@eggyal eggyal deleted the gatsubstcollector-without-folding branch June 19, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants