Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIR Dataflow chapter needs corrections since the latest changes #2113

Closed
marxin opened this issue Nov 2, 2024 · 1 comment · Fixed by #2121
Closed

MIR Dataflow chapter needs corrections since the latest changes #2113

marxin opened this issue Nov 2, 2024 · 1 comment · Fixed by #2121
Assignees
@nnethercote
Labels
A-MIR Area: mid-level intermediate representation (MIR) C-broken-links Category: broken links E-medium Difficulty: might require some prior knowledge or code reading I-outdated Issue: info is outdated T-compiler Relevant to compiler team

Comments

@marxin
Copy link
Contributor

marxin commented Nov 2, 2024

Since rust-lang/rust#131481, the following 404 link issues have been reported:

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_dataflow/trait.AnalysisDomain.html
error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_dataflow/trait.GenKillAnalysis.html
error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_dataflow/struct.Engine.html
error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightlyrustc/rustc_mir_dataflow/trait.AnalysisDomain.html#associatedconstant.NAME
error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_dataflow/move_paths/builder/struct.Gatherer.html
error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_dataflow/move_paths/builder/struct.Gatherer.html#method.move_path_for

Can you please take a look @nnethercote?
@jieyouxu jieyouxu added C-broken-links Category: broken links A-MIR Area: mid-level intermediate representation (MIR) T-compiler Relevant to compiler team I-outdated Issue: info is outdated E-medium Difficulty: might require some prior knowledge or code reading labels Nov 2, 2024
@nnethercote nnethercote self-assigned this Nov 3, 2024
@nnethercote
Copy link
Contributor

I'll take a look.

nnethercote added a commit to nnethercote/rustc-dev-guide that referenced this issue Nov 4, 2024
@nnethercote
Update for recent dataflow simplifications.
dc59952 
E.g. rust-lang/rust#130022 and
rust-lang/rust#131481.

Fixes rust-lang#2113.
@nnethercote nnethercote mentioned this issue Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnethercote nnethercote

Labels
A-MIR Area: mid-level intermediate representation (MIR) C-broken-links Category: broken links E-medium Difficulty: might require some prior knowledge or code reading I-outdated Issue: info is outdated T-compiler Relevant to compiler team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for recent dataflow simplifications. nnethercote/rustc-dev-guide
3 participants
@nnethercote @marxin @jieyouxu