Do not remove fn headers (e.g., async) on extern fn items #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
reviewed
Jun 30, 2020
src/formatting/items.rs
Outdated
| @@ -235,18 +235,18 @@ pub(crate) struct FnSig<'a> { | |||
|
|
|||
| impl<'a> FnSig<'a> { | |||
| pub(crate) fn new( | |||
There was a problem hiding this comment.
I think it may be easier to use from_method_sig, which allows for dropping this method entirely. See https://github.com/rust-lang/rustfmt/pull/4290/files
There was a problem hiding this comment.
Good point! I like this idea better than mine. Thank you for creating the PR, and no worries about the duplicated work. GitHub UI is laggy these days.
There was a problem hiding this comment.
Related aside, we should probably rename from_method_sig to from_fn_sig at some point in the future. Believe that's one that we missed when incorporating the upstream rustc Method -> Fn renaming
Closes rust-lang#4288 And we get to drop a method, which I think is a win :)
topecongiro
force-pushed
the
async-fn-in-extern
branch
from
9568e3e to
07fa1ca
Compare
|
You both jumped on that one fast 😄 |
calebcartwright
approved these changes
Jun 30, 2020
This was referenced Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4288.