Fix non-inlined fn calls for some arm vfma intrinsics #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Amanieu
reviewed
Sep 10, 2021
| #[cfg_attr(target_arch = "arm", target_feature(enable = "fp-armv8,v8"))] | ||
| #[cfg_attr(all(test, target_arch = "arm"), assert_instr("vdup.32"))] | ||
| #[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(dup))] | ||
| unsafe fn vdupq_n_f32_v8(value: f32) -> float32x4_t { |
There was a problem hiding this comment.
Can you add a comment explaining why this is needed? Also this should probably be under #[cfg(target_arch = "arm")].
There was a problem hiding this comment.
@Amanieu Will do, but first I will fix arm fused multiply-add to only require vfp4 instead of v8 (PR forthcoming) and then the fn name will change to vdupq_n_f32_vfp4.
|
Superseded by #1219. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some VFMA functions have
target_feature(enable = "fp-armv8,v8")while the called functionsvdup_n_f32andvdupq_n_f32aretarget_feature(enable = "v7"). LLVM does not inline the functions due to the different feature flags. Using private _v8 variants of those functions causes them to be inlined.