-
Notifications
You must be signed in to change notification settings - Fork 114
Resolved shared library issues and expose C and C++ build tools #232
Conversation
…nvironment that exposes C/C++ toolchains.
@mb64 tests are failing due to a docker issue. Will fix and push later tonight. |
@mb64 all the issues have been resolved. The docker issue should be fixed as well. Tests are running. The docker issue was due to the rust docker image apparently defaulting to a new version of debian. We could stick with a version that uses the older version but I think we might as well build with the latest. Once again, due to the number of commits, I recommend squashing once it is time to merge. |
@mb64 tests failed so I"m looking into it. |
@mb64 fixed it. Switched back to using stretch for docker image after all. Android SDK has compatibility issues with JDK 11. |
Sorry for the delay – I've just finally gotten around to this again, and a few things caught my attention:
No other issues with this have come up, so I'll merge. |
This pull request resolved #230. It removes the use of
ndk-build
and instead builds the shared library directly for the reasons described in that issue. In addition, it sets environment variables and generates a CMake toolchain based on the build targets and themin_sdk_version
to allow crates which use thecc
andcmake
crates to build properly.