ndk/media_format: Make all mutating functions take self by &mut

[MarijnS95]

Fixes #451, CC @zarik5

All setters can inherently change the internals of the format, and should furthermore invalidate - or not be allowed while - borrowed strings or buffers (are) acquired from it.

Unforatunately getString() is documented as:

The returned string is owned by the format, and remains valid until the next call to getString, or until the format is deleted.

Meaning that it is not reentrant, and invalidates any data previously acquired from str(); hence this getter is marked as &mut self too. The same is however not the case for getBuffer().

[spencercw]

The doc comments on buffer and str seem a little redundant because the rules are enforced by the type system anyway. The str comment is also not strictly accurate because the string is only invalidated when you re-fetch the same key.¹ Not suggesting we should add document this implementation detail, but I don't think the adapted NDK docs are adding much value.

Looks good otherwise.

Footnotes

1. https://cs.android.com/android/platform/superproject/main/+/main:frameworks/av/media/ndk/NdkMediaFormat.cpp;l=232-258;drc=65d530890d50e7a39f29fc70c0b6e55b402fe10a ↩

[MarijnS95]

Fair enough for buffer, I mostly copied the NDK docs for the few (two) functions that actually have docs upstream.

I'd like to keep "something" for fn str() however, to justify to documentation readers why a getter is borrowing self mutably.

[spencercw]

Yes that makes sense. A mut getter does look a bit odd on the face of it.