ndk/bitmap: Gate BitmapCompressError behind api-level-30
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that is fair even though this will all be deleted again soon. We cannot merge, yank, and re-release this without a changelog entry though. |
…pressError` Otherwise there is a compilation error when building with only the feature `bitmap`, due to the inexistence of the `DataSpace` type. `DataSpace` is defined with `api-level-28`, but this type is only used by `Bitmap::compress()` and `Bitmap::compress_raw()`, which are only available with `api-level-30`.
Rodrigodd
force-pushed
the
fix-bitmap-build
branch
from
75d9c06 to
0c0809e
Compare
|
@MarijnS95 Added a changelog entry. |
MarijnS95
reviewed
Jan 4, 2024
MarijnS95
approved these changes
Jan 4, 2024
MarijnS95
reviewed
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise there is a compilation error when building with only the feature
bitmap, due to the inexistence of theDataSpacetype.DataSpaceis defined withapi-level-28, but thisBitmapCompressErroris only used byBitmap::compress()andBitmap::compress_raw(), which are only available withapi-level-30.