-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cargo.lock to prevent nightly breakage #129
Conversation
Thanks! Could you also update the Cargo.lock files in |
@phil-opp This needs to be force merged
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@phil-opp It looks like one of the tests got (inadvertently) cancelled. I don't have permissions to rerun them. |
Signed-off-by: Joe Richey <[email protected]>
Seems like the Windows job is having some problems downloading QEMU. I already restarted it once after seeing the same issue. Let's try it again… |
Looks like a network failure. The Windows test consistently fails in downloading (the link works just fine for me locally though) |
I also just tried it locally and it worked for me too. I'm not sure what we should do about this. I'm inclined to force-merge and publish to unblock the nightly features, but on the other hand it feels not good to publish a new version without a passing CI. |
It's building and all the other tests and stuff are passing. The downside here is that without this change, the CI's for all the other projects aren't going to pass. Given that this would be the only change for |
Thanks! Ok, then let's do this. |
Published as v0.9.11 |
See rust-osdev/x86_64#186 (comment)
Now that x86_64 has a "good" build, we just need a new lockfile to make things build.
Signed-off-by: Joe Richey [email protected]