Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condition for running bootloader common tests #487

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Jan 21, 2025

There's no 'x86' arch. There is 'X86', but we currently don't any CI job on a 32-bit target, so this still wouldn't work. Let's just use X64.

There's no 'x86' arch. There is 'X86', but we currently don't any CI job on a
32-bit target, so this still wouldn't work. Let's just use X64.
@Freax13 Freax13 requested a review from phil-opp January 21, 2025 15:54
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 5d06f60 into rust-osdev:main Jan 21, 2025
7 of 8 checks passed
@phil-opp phil-opp mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants