atomic_bitmap: add capability to reset bits range #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russell-islam
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
russell-islam
force-pushed
the
muislam/reset-atomic-bitmap
branch
from
f23405b to
3ce1612
Compare
00xc
reviewed
Nov 23, 2023
russell-islam
force-pushed
the
muislam/reset-atomic-bitmap
branch
2 times, most recently
from
65d1d37 to
8711bdc
Compare
roypat
previously approved these changes
Dec 13, 2023
00xc
reviewed
Dec 29, 2023
src/bitmap/backend/atomic_bitmap.rs
Outdated
| /// is for the page corresponding to `start_addr`, and the last bit that we set corresponds | ||
| /// to address `start_addr + len - 1`. | ||
| pub fn reset_addr_range(&self, start_addr: usize, len: usize) { | ||
| self.set_reset_addr_range(start_addr, len, true); |
There was a problem hiding this comment.
Just a nitpick, but it's a bit counter-intuitive in my opinion that the third argument being set to true means that the bits are set to zero, I would expect the opposite. Otherwise LGTM.
There was a problem hiding this comment.
@00xc Fixed now
russell-islam
force-pushed
the
muislam/reset-atomic-bitmap
branch
from
bfe91ca to
4d4df5c
Compare
roypat
approved these changes
Jan 5, 2024
|
@00xc Could you please take another look into this PR? |
Currently, there is no implementation to reset a single bit or bit range for AtomicBitmap struct. This patch adds necessary function to reset a specific bit or a bit range. This use case is needed for Cloud-Hypervisor in managing page cache for Microsoft Hypervisor related to SEV-SNP guest. Rather than implementing a new one , it is helpful to add feature to this struct. Signed-off-by: Muminul Islam <[email protected]>
russell-islam
force-pushed
the
muislam/reset-atomic-bitmap
branch
from
4d4df5c to
172427a
Compare
00xc
approved these changes
Jan 22, 2024
|
Pinging again: @alexandruag @bonzini @jiangliu |
JonathanWoollett-Light
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no implementation to reset a single bit or bit range for AtomicBitmap struct. This patch adds necessary function to reset a specific bit or a bit range. This use case is needed for Cloud-Hypervisor in managing page cache for Microsoft Hypervisor related to SEV-SNP guest. Rather than implementing a new one , it is helpful to add feature to this struct.
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.