Add a useful WebAssembly API #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns the results of the analyses as a JSON string.
It won't work, and we really want to do `JOB=wasm ./ci/script.sh` instead.
| @@ -0,0 +1,114 @@ | |||
| // Fun times ahead! | |||
| // | |||
| // Apparently, proc-macros don't play well with `cfg_attr` yet, and their | |||
There was a problem hiding this comment.
FWIW the upstream bug should be closed now so once we have a new nightly this should be working again
There was a problem hiding this comment.
And we will be able to remove the build.rs that preprocesses definitions.rs and everything will Just Work? If so: 🎉
|
That's the theory at least!
…On Tue, Apr 17, 2018, 6:23 PM Nick Fitzgerald ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In opt/definitions.rs
<#36 (comment)>:
> @@ -0,0 +1,114 @@
+// Fun times ahead!
+//
+// Apparently, proc-macros don't play well with `cfg_attr` yet, and their
And we will be able to remove the build.rs that preprocesses
definitions.rs and everything will Just Work? If so: 🎉
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95G-rmziHytbsyPi6a5Ts95qgx14_ks5tpnlkgaJpZM4TZIRe>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the results of the analyses as a JSON string.