adds coverage reporting using nyc and coveralls #48
Conversation
| @@ -25,6 +27,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "bl": ">=0.9.0 <0.10.0-0", | |||
| "coveralls": "^2.11.2", | |||
There was a problem hiding this comment.
@rvagg any reason? Just curious (happy if you just throw a blog link my way), wouldn't ^2.11.0 catch more fixes for [potential] bugs (assuming they follow semver)?
There was a problem hiding this comment.
Hey @rvagg I'll update this shortly. @dcousens, one could argue the other side that you're more likely to get bugs with ^, since you're pulling in new features (in a perfect world, this would not break the API but with new features comes more code churn). I tend towards ^, because I like to live dangerously, but I can understand the other side of the argument.
There was a problem hiding this comment.
@bcoe true, but I don't know many library authors that would back port fixes to older minor versions of their library, even if that fix could be applied to previous minor versions.
There was a problem hiding this comment.
@dcousens see my latest rant on the topic starting here: https://twitter.com/rvagg/status/602642984845254656 (follow link in that tweet and read the replies on twitter)
|
rebase? |
|
@rvagg merge? |
|
sorry, doesn't work for me on my current computer because I have /tmp mounted noexec, which is not uncommon on many Linux systems, primarily Ubuntu, and |
|
@bcoe are you going to fix the issue and reopen this? |
|
@stevemao see the discussion taking shape on spawn-wrap, sounds like we could potentially hammer something out that makes everyone happy. |
|
Rebase or close? |
|
added basic |
This pull adds test coverage, facilitated by nyc and the hosted coverage service coveralls.io.
npm run coverageto get a human readable coverage report.npm run coverage -- --reporter=lcovto get an HTML report over coverage in the /coverage folder.npm run coverallsto report coverage to the coveralls.io.COVERALLS_REPO_TOKEN.COVERALLS_REPO_TOKEN