Graceful shutdown timeout #1374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
notriddle
force-pushed
the
async
branch
8 times, most recently
from
296233e to
15546fa
Compare
notriddle
force-pushed
the
async
branch
2 times, most recently
from
e12adfd to
c01b864
Compare
This implements the "instant shutdown" flag describe in rwf2#180. rwf2#180 (comment)
notriddle
force-pushed
the
async
branch
12 times, most recently
from
1cb09b1 to
3c71840
Compare
notriddle
force-pushed
the
async
branch
4 times, most recently
from
003676f to
def8225
Compare
|
This was discussed on Matrix long ago and we reached the conclusion that the API exposed here is not one we want to move forward with. Thank you for the contribution, however, @notriddle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some feedback, this PR also adds a graceful shutdown
wait()function.