Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the skeleton of a capability-based layout #71

Merged
merged 6 commits into from
May 30, 2023

Conversation

jemrobinson
Copy link
Contributor

@jemrobinson jemrobinson commented May 25, 2023

✅ Checklist

  • This pull request has a meaningful title.
  • If your changes are not yet ready to merge, you have marked this pull request as a draft pull request.

☑️ Maintainers' checklist

  • This pull request has had the appropriate labels assigned
  • This pull request has been added to the SATRE backlog project board
  • This pull request has been assigned to one or more maintainers

⤴️ Summary

Add the capabilities-based skeleton discussed in the last WP1 meeting.

Main page

Screenshot 2023-05-25 at 12 14 21

Standard specification page

Screenshot 2023-05-25 at 12 14 34

🌂 Related issues

n/a

🙋 Acknowledging contributors

@jemrobinson jemrobinson requested review from manics and JimMadge May 25, 2023 10:35
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good. A few (slightly opinionated) grammar things.

@jemrobinson
Copy link
Contributor Author

@manics @JimMadge : If you're happy with the discussion points above, can you resolve them? If not, can you suggest a change you'd like to see? Should this PR stay up for comment for the full 7 days or is it ready to merge?

@JimMadge
Copy link
Member

I've changed my review as I don't see any reason to block this.

My take on the lazy consensus model was that 7 days with no objections is approval, but that isn't to say things can't be approved before 7 days. It might be worth giving this some more time for others to look at?

@jemrobinson jemrobinson merged commit f1a5636 into main May 30, 2023
@manics manics deleted the separate-into-capabilities branch May 30, 2023 14:11
@jemrobinson
Copy link
Contributor Author

@all-contributors please add @jemrobinson for content design ideas projectManagement

@allcontributors
Copy link
Contributor

@jemrobinson

I've put up a pull request to add @jemrobinson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants