Dependency Process Refactoring

src/GitHunter.Application/Git/GitProcessDependency.cs

@@ -6,6 +6,11 @@ public bool Check()
     {
         var environmentVariable = Environment.GetEnvironmentVariable("PATH");
         var paths = environmentVariable?.Split(';');
-        return paths != null && paths.Any(path => File.Exists(Path.Combine(path, "git.exe")));
+        return paths != null && paths.Any(path => File.Exists(Path.Combine(path, ProcessName)));
     }
+
+    public string ProcessName => "git.exe";
+    public string ErrorMessage => "Git is not installed. Please download and install Git from " + DownloadUrl;
+    public string ErrorTitle => "Git not found";
+    public string DownloadUrl => "https://git-scm.com/downloads";
 }

src/GitHunter.Application/LanguageStatistics/SourceMonitor/SourceMonitorProcessDependency.cs

@@ -9,4 +9,9 @@ public bool Check()
     {
         return File.Exists(Resource.SourceMonitor.SourceMonitorExe.Path);
     }
+
+    public string ProcessName => "SourceMonitor";
+    public string ErrorMessage => $"SourceMonitor.exe not found. Please download it from {DownloadUrl} and place it in the same folder as GitHunter Resources.";
+    public string ErrorTitle => "SourceMonitor.exe not found";
+    public string DownloadUrl => "https://www.campwoodsw.com/sourcemonitor.html";
 }

src/GitHunter.Core.Shared/DependencyProcesses/IProcessDependency.cs

@@ -3,4 +3,12 @@
 public interface IProcessDependency
 {
     bool Check();
+
+    string ProcessName { get; }
+
+    string ErrorMessage { get; }
+
+    string ErrorTitle { get; }
+
+    string? DownloadUrl { get; }
 }

src/GitHunter.Core.Shared/DependencyProcesses/IProcessDependencyChecker.cs

@@ -4,5 +4,5 @@ namespace GitHunter.Core.DependencyProcesses;
 
 public interface IProcessDependencyChecker
 {
-    bool CheckDependency(Assembly assembly);
+    bool CheckDependency(Assembly assembly, out IProcessDependency? dependency);
 }

src/GitHunter.Core/CoreModule.cs

@@ -22,8 +22,8 @@ public override void OnApplicationInitialization(ApplicationInitializationContex
                 var modules = ModuleHelper.FindGitHunterModuleTypes(processDependencyOptions.StartupModule);
 
                 foreach (var assembly in modules.Select(m => m.Assembly))
-                    if (!processDependencyChecker.CheckDependency(assembly))
-                        processDependencyOptions.ErrorAction?.Invoke();
+                    if (!processDependencyChecker.CheckDependency(assembly, out var dependency))
+                        processDependencyOptions.ErrorAction?.Invoke(dependency);
             }
         }
 

src/GitHunter.Core/DependencyProcesses/ProcessDependencyChecker.cs

@@ -13,8 +13,9 @@ public ProcessDependencyChecker(IServiceProvider serviceProvider)
         _serviceProvider = serviceProvider;
     }
 
-    public bool CheckDependency(Assembly assembly)
+    public bool CheckDependency(Assembly assembly, out IProcessDependency? processDependency)
     {
+        processDependency = null;
         var dependenciesTypes = assembly.GetTypes().Where(t =>
             t.GetCustomAttributes(typeof(ProcessDependencyAttribute<>)) is { } attributes && attributes.Any());
         var dependenciesAttributes = dependenciesTypes
@@ -26,6 +27,15 @@ public bool CheckDependency(Assembly assembly)
             return null;
         });
 
-        return dependencies.All(d => d != null && d.Check());
+        foreach (var dependency in dependencies)
+        {
+            if (dependency == null)
+                continue;
+            if (dependency.Check()) continue;
+            processDependency = dependency;
+            return false;
+        }
+
+        return true;
     }
 }

src/GitHunter.Core/DependencyProcesses/ProcessDependencyOptions.cs

@@ -4,5 +4,5 @@ public class ProcessDependencyOptions
 {
     public Type? StartupModule { get; set; }
 
-    public Action? ErrorAction { get; set; }
+    public Action<IProcessDependency?>? ErrorAction { get; set; }
 }

src/GitHunter.Desktop.WindowsForm/DesktopWindowsFormModule.cs

@@ -1,4 +1,5 @@
-using GitHunter.Application;
+using System.Diagnostics;
+using GitHunter.Application;
 using GitHunter.Core.DependencyProcesses;
 using GitHunter.Core.Modules;
 using Volo.Abp.Modularity;
@@ -14,7 +15,15 @@ public override void ConfigureServices(ServiceConfigurationContext context)
         Configure<ProcessDependencyOptions>(o =>
         {
             o.StartupModule = typeof(DesktopWindowsFormModule);
-            o.ErrorAction = () => { MessageBox.Show("Error"); };
+            o.ErrorAction = (pd) =>
+            {
+                var text = pd?.ErrorMessage + Environment.NewLine + "Do you want to download it now?";
+                if(MessageBox.Show(text, pd?.ErrorTitle, MessageBoxButtons.YesNo, MessageBoxIcon.Asterisk) == DialogResult.Yes)
+                {
+                    if (pd?.DownloadUrl != null) Process.Start("explorer", pd.DownloadUrl);
+                }
+                Environment.Exit(0);
+            };
         });
 
         base.ConfigureServices(context);