Struct field ingredients #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step towards the new tracked struct design. SUBTLE: This is actually broken if the `#[id]` fields have a broken hash. We'll fix that in the next commit and add a test.
✅ Deploy Preview for salsa-rs canceled.
|
We do care about the order of things in this set, in general, so use `shift_remove`.
solson
reviewed
Apr 2, 2024
nikomatsakis
force-pushed
the
struct-field-ingredients
branch
from
c631651 to
8772961
Compare
| revision: crate::Revision, | ||
| ) -> bool { | ||
| let id = <C::Id>::from_id(input.key_index.unwrap()); | ||
| eprintln!("maybe_changed_after({id:?}, {revision:?})"); |
There was a problem hiding this comment.
Hi @nikomatsakis , I noticed that an eprintln!() statement was accidentally left in the PR. Could you please check and remove it if it's not needed? Thanks!
There was a problem hiding this comment.
Whoops! Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch overhauls how tracked structs are implemented to make them more efficient -- it also adds tests for some edge cases along the way. In the new design, instead of treating tracked structs like a bunch of functions with specified values (omg the hashing) it creates a single shared hashmap to map the tracked struct id to its fields.
The plan is to eventually transition to a "Salsa 3.0" design in which tracked structs can be literal pointers into this shared value, but that will require more extensive changes that I have to write-up and think through (there are some edge cases in the unsafe code that are a bit subtle). This seemed like a useful stopping point regardless.