Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashmap, hashlink, and rustc-hash #514

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Jul 1, 2024

Update dashmap, hashlink and rustc-hash to the most recent major version.

dashmap

This release contains performance optimizations, most notably 10-40% gains on Apple Silicon but also 5-10% gains when measured in Intel Sapphire Rapids. This work was accomplished in:

It's a major because there's a slight API change.

hashlink

API incompatible change: Don't panic in reserve and try_reserve in cases where a rehash is needed. Previously would panic, adds the proper bounds on reserve methods to do a rehash (previously bounds were missing, and reserve would result in panics). (Thank you cuviper!)

I think that's fine

rustc-hash

Replace hash with faster and better finalized hash. This replaces the previous "fxhash" algorithm originating in Firefox with a custom hasher designed and implemented by Orson Peters (orlp). It was measured to have slightly better performance for rustc, has better theoretical properties and also includes a signficantly better string hasher.

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 151c48b
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/669e5c3fb1b339000827de92

@davidbarsky
Copy link
Contributor

Using this commit against https://github.com/davidbarsky/salsa-benchmarks/, I saw an 11-12% improvement (418.66ns versus 466.92ns on compare/new_salsa_length/1).

@nikomatsakis
Copy link
Member

Needs rebase but r=me

@MichaReiser
Copy link
Contributor Author

@nikomatsakis done

@nikomatsakis nikomatsakis added this pull request to the merge queue Jul 22, 2024
Merged via the queue into salsa-rs:master with commit b8bbf96 Jul 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants