feature: add #[salsa::supertype]
#727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are of the form:
```
enum Enum {
Input(Input),
Interned(Interned),
...
}
```
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #727 will not alter performanceComparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-rqvpzyoqspzn
branch
from
ff88db0 to
3e0b921
Compare
Veykril
changed the title
#[salsa::supertype]
Veykril
force-pushed
the
veykril/push-rqvpzyoqspzn
branch
from
3e0b921 to
e6f53c6
Compare
Veykril
force-pushed
the
veykril/push-rqvpzyoqspzn
branch
from
e6f53c6 to
2241b1b
Compare
Veykril
force-pushed
the
veykril/push-rqvpzyoqspzn
branch
from
2241b1b to
31c310f
Compare
davidbarsky
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Given that:
- I authored a chunk of this,
- Reviewed Lukas' changes, and
- The performance regressions are fixed
I feel comfortable landing this change. @MichaReiser do the benchmark figures look good to you/acceptable to Ruff?
|
They look great. I don't see how I can complain when they're all neutral or improvements. Thanks for paying so close attention to performance! |
|
Sounds good! I'll land this and close #677. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#677 but rebased + commit that hopefully reduces perf regression