Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ChatGptTypeChecker and LlmTypeCheckerV3. #113

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Dec 16, 2024

ChatGptTypeChecker had not considered additionalProperties case, and LlmTypeCheckerV3 had not defined the visitor function.


This pull request includes several updates to the ChatGptTypeChecker and LlmTypeCheckerV3 namespaces, as well as adding new test cases for type checker validation. The most important changes include enhancements to the handling of additional properties in schemas, the addition of a new covers function in LlmTypeCheckerV3, and the creation of new test files for validating type checker coverage.

Enhancements to schema handling:

New covers function:

  • src/utils/LlmTypeCheckerV3.ts: Added a new covers function that checks if one schema can cover another, including internal helper functions for covering boolean, integer, number, string, array, and object types.

New test cases:

Version update:

`ChatGptTypeChecker` had not considered `additionalProperties` case, and `LlmTypeCheckerV3` had not defined the visitor function.
@samchon samchon added bug Something isn't working enhancement New feature or request labels Dec 16, 2024
@samchon samchon self-assigned this Dec 16, 2024
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@samchon samchon merged commit 955f41a into master Dec 16, 2024
4 checks passed
@samchon samchon deleted the feat/chatgpt branch December 16, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant