Add support for sanity::documentsOf() #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzhelyazkova
previously approved these changes
Aug 7, 2024
src/evaluator/functions.ts
Outdated
| if (value.type !== 'string') return NULL_VALUE | ||
| const baseId = value.data | ||
|
|
||
| // All the document belong to a bundle ID if: |
There was a problem hiding this comment.
Suggested change
| // All the document belong to a bundle ID if: | |
| // All the documents belong to a bundle ID if: |
There was a problem hiding this comment.
or "A document belongs to a bundle ID if:"
|
@tzhelyazkova another review please. |
tzhelyazkova
approved these changes
Aug 8, 2024
I approved the last time when I left that comment, so you don't have to depend on that to merge but idk what happened 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new function
sanity::documentsOf()which lists all the document IDs that are part of a given bundle ID in arg.