Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknowns #261

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Handle unknowns #261

merged 1 commit into from
Aug 23, 2024

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Aug 23, 2024 •
edited
Loading

This PR changes so that mapConcrete also returns unknown, then it's up to the caller to handle these cases. Most notable this let us do unions of null/expectedType when unknown given

@sgulseth sgulseth marked this pull request as draft August 23, 2024 08:20
@sgulseth sgulseth changed the title feat(typeEvaluator): remove resolve condition, use walk to determine conditions Handle unknowns Aug 23, 2024
@sgulseth sgulseth marked this pull request as ready for review August 23, 2024 08:28
judofyr
judofyr previously approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@judofyr judofyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Interesting that none of tests had to be changed. I guess we don't have so much specific tests for these unknown cases.

Base automatically changed from feat/typeevaluator/resolve-condition to main August 23, 2024 10:46
@sgulseth sgulseth dismissed judofyr’s stale review August 23, 2024 10:46

The base branch was changed.

@sgulseth sgulseth force-pushed the feat/typeevaluator/handle-unknowns branch from dc23a98 to 0983680 Compare August 23, 2024 10:48
@sgulseth sgulseth enabled auto-merge (rebase) August 23, 2024 10:56
@sgulseth sgulseth requested a review from judofyr August 23, 2024 10:56
@sgulseth sgulseth disabled auto-merge August 23, 2024 10:57
@sgulseth sgulseth enabled auto-merge (rebase) August 23, 2024 10:57
@sgulseth sgulseth disabled auto-merge August 23, 2024 11:01
@sgulseth sgulseth merged commit 41679a3 into main Aug 23, 2024
8 checks passed
@sgulseth sgulseth deleted the feat/typeevaluator/handle-unknowns branch August 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judofyr judofyr Awaiting requested review from judofyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgulseth @judofyr