Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.editorconfig pattern for GNUmakefile.am incorrect #2885

Closed
craigbarnes opened this issue Apr 29, 2019 · 0 comments · Fixed by #2935
Closed

.editorconfig pattern for GNUmakefile.am incorrect #2885

craigbarnes opened this issue Apr 29, 2019 · 0 comments · Fixed by #2935

Comments

@craigbarnes
Copy link
Contributor

craigbarnes commented Apr 29, 2019 •
edited
Loading

The .editorconfig file currently contains the pattern:

[{Makefile, GNUmakefile.am}]

The space at the start of GNUmakefile.am is matched literally and so doesn't actually match the GNUmakefile.am file in the repo.
nschonni added a commit to nschonni/libsass that referenced this issue Jun 28, 2019
@nschonni
fix: ExitorConfig glob for Makefiles
d6606e3 
Fixes sass#2885
@nschonni nschonni mentioned this issue Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ExitorConfig glob for Makefiles nschonni/libsass
1 participant
@craigbarnes